Re-enable PHPStan level 5 arguments.count warning, fix all warnings - #1617
Merged
Conversation
Most of these were spurious and an effect of PHPStan treating all our
*.php files as being in the same namespace: we occasionally have
functions with identical names but different signatures defined in
different *.php files and PHPStan gets confused by this.
The proper fix would be to add a unique `namespace Foo;` to the top
of each PHP file, but for now I just add a unique prefix to the
conflicting function name with.
arguments.count did catch one real error:
`sprintf(_('template %1$s %2$s', $arg1, $arg2))` instead of
`sprintf(_('template %1$s %2$s'), $arg1, $arg2))`
cpeel
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most of these were spurious and an effect of PHPStan treating all our *.php files as being in the same namespace: we occasionally have functions with identical names but different signatures defined in different *.php files and PHPStan gets confused by this.
The proper fix would be to add a unique
namespace Foo;to the top of each PHP file, but for now I just add a unique prefix to the conflicting function name with.arguments.count did catch one real error:
sprintf(_('template %1$s %2$s', $arg1, $arg2))instead ofsprintf(_('template %1$s %2$s'), $arg1, $arg2))