Output: sync WebSocket settings with UI - #1493
Open
iibaranov-IG wants to merge 1 commit into
Open
iibaranov-IG wants to merge 1 commit into
iibaranov-IG wants to merge 1 commit into
Conversation
Persist remote NDI name and group changes for the managed main and preview outputs. The output settings dialog then reloads the active values instead of stale configuration.
iibaranov-IG
marked this pull request as ready for review
September 11, 2026 16:11
Contributor
|
Thanks for taking the initiative to fix this issue! I tested your changes with the I found the following issues:
These scenarios are already fixed and tested in #1472, it is just pending a merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SetOutputSettingsupdated the livendi_outputinstance, while the DistroAV output dialog continued to load its name and groups from the plugin configuration. As a result, a WebSocket change succeeded but the dialog displayed the previous values.This change identifies updates for DistroAV's managed main and preview outputs, mirrors their
ndi_nameandndi_groupsinto the corresponding plugin configuration, and persists changes only when values differ. Dedicated NDI outputs are unaffected.Closes #1438.
Validation:
git diff --check