W7 platform quality: poor-network resilience, locale-aware formatting, and accessibility fixes by Queen-T16 · Pull Request #151 · DocForum/docforum-web

Queen-T16 · 2026-10-18T22:41:32Z

Closes #85,
Closes #88,
Closes #89,
Closes #90

drips-wave · 2026-10-18T22:43:18Z

@Queen-T16 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

…cy, and safe mutation retries

…okup loading state - Closes DocForum#90

afeezorobsco-cyber · 2026-10-19T06:48:48Z

@Queen-T16

CI fails at npm ci: package.json and package-lock.json are not in sync. The lock file is missing @jest/expect-utils, @jest/get-type, jest-matcher-utils, jest-message-util and more, all pulled in by @types/jest-axe. Run npm install and commit the updated package-lock.json.

Also, this consolidates #146, which conflicts with main. If #151 supersedes it, please close #146.

afeezorobsco-cyber · 2026-10-20T05:16:28Z

@Queen-T16 Thanks for the PR. It can't be merged yet. To unblock it:

CI is failing. Here's what broke:

Frontend (typecheck + test + build):

npm ci: package.json and package-lock.json are out of sync (Missing: @jest/expect-utils@30.5.2 from lock file). Run `npm install` and commit the updated package-lock.json.

Please fix these errors and run the same steps locally before pushing (npm run typecheck && npm test && npm run build, or cargo test for contracts).

Branch protection also requires the branch to be up to date with main, so please rebase onto the latest main when you push the fix.

Push to this same branch and CI will re-run. Once it's green and conflict-free, it'll be reviewed for merge.

github-actions · 2026-10-20T09:29:05Z

@Queen-T16 This PR now has merge conflicts with main, most likely because #178 (ci: load workflow scripts as .cjs (fixes notifier/scan under "type": "module")) was just merged, so it can't be merged until it's rebased:

git fetch upstream            # upstream = https://github.com/DocForum/docforum-web.git
git rebase upstream/main
# resolve the conflicts, re-run the tests, then:
git push --force-with-lease

The usual culprits are shared files like ROADMAP.md and ARCHITECTURE*.md. CI re-runs when you push, and the needs-rebase label is removed automatically once the conflicts are resolved.

_{Automated message. It won't repeat unless the PR conflicts again after your next push.}

…ality-consolidated # Conflicts: # package-lock.json # package.json # src/components/Layout.tsx # src/features/auth/components/LoginForm.tsx # src/features/auth/components/SignupForm.tsx # src/features/consultation/components/ConsultationNote.tsx # src/features/payments/components/CreatePaymentIntentForm.tsx # src/features/payments/hooks/useWalletLink.ts # src/pages/DoctorDashboardPage.tsx # src/services/api-client.test.ts # src/services/api-client.ts

github-actions · 2026-10-22T17:11:02Z

@Queen-T16 This PR now has merge conflicts with main, most likely because #190 (feat(search): search across my own records) was just merged, so it can't be merged until it's rebased:

git fetch upstream            # upstream = https://github.com/DocForum/docforum-web.git
git rebase upstream/main
# resolve the conflicts, re-run the tests, then:
git push --force-with-lease

The usual culprits are shared docs like ROADMAP.md and ARCHITECTURE*.md. If the conflict is in the ROADMAP.md changelog, move your entry into a new file under changelog.d/ (see changelog.d/README.md) rather than resolving it in place, so it can't conflict again. CI re-runs when you push, and the needs-rebase label is removed automatically once the conflicts are resolved.

_{Automated message. It won't repeat unless the PR conflicts again after your next push.}

afeezorobsco-cyber · 2026-10-22T17:34:07Z

@Queen-T16 CI is failing on this branch against the latest main, so it can't be merged yet. The errors from the latest run:

Frontend (typecheck + test + build)

AggregateError: 
    Error: connect ECONNREFUSED ::1:4000
    Error: connect ECONNREFUSED 127.0.0.1:4000
    Error: connect ETIMEDOUT ::1:4000
QR generation failed TypeError: Cannot read properties of null (reading 'createImageData')
     × associates validation errors with the field and focuses it 85ms
 FAIL  src/features/auth/components/LoginForm.a11y.test.tsx > LoginForm accessibility (#89) > associates validation errors with the field and focuses it
Error: expect(element).toHaveFocus()

A test makes real requests to localhost:4000 (ECONNREFUSED). Add a mock handler for the new request in src/mocks/handlers. Tests must never reach a real backend.

This PR also conflicts with main again, so please rebase first, then fix the above.

- Add MSW setupServer to src/test/setup.ts to mock all API calls - Fixes ECONNREFUSED errors in admin/console tests - Fixes LoginForm a11y focus test - Fixes QR generation TypeError in OrderDetailPage - Eliminates act() warnings from unmocked state updates - Add form dependencies for LoginForm/SignupForm

afeezorobsco-cyber · 2026-10-24T19:10:17Z

@Queen-T16 This PR conflicts with main again after your latest push, so it can't be merged yet. Please rebase onto the latest main:

git fetch upstream
git rebase upstream/main
# fix the conflicts, then
git push --force-with-lease

If the conflict is in ROADMAP.md's changelog, move your entry into a changelog.d/ fragment instead of editing ROADMAP.md.

- Add MSW setupServer to src/test/setup.ts to mock all API calls in tests - Add minimal mock infrastructure (handlers, fixtures, db) for tests - Add query-client.ts for React Query client - Fixes ECONNREFUSED errors in admin/console tests - Fixes LoginForm a11y focus test - Fixes QR generation TypeError in OrderDetailPage - Eliminates act() warnings from unmocked state updates - Add form dependencies (react-hook-form, @hookform/resolvers, zod) - Add jest-axe and msw for testing

github-actions · 2026-10-24T21:00:46Z

@Queen-T16 This PR now has merge conflicts with main, most likely because #209 (chore(deps): upgrade jspdf to v4 and patch vite to clear audit advisories) was just merged, so it can't be merged until it's rebased:

git fetch upstream            # upstream = https://github.com/DocForum/docforum-web.git
git rebase upstream/main
# resolve the conflicts, re-run the tests, then:
git push --force-with-lease

The usual culprits are shared docs like ROADMAP.md and ARCHITECTURE*.md. If the conflict is in the ROADMAP.md changelog, move your entry into a new file under changelog.d/ (see changelog.d/README.md) rather than resolving it in place, so it can't conflict again. CI re-runs when you push, and the needs-rebase label is removed automatically once the conflicts are resolved.

_{Automated message. It won't repeat unless the PR conflicts again after your next push.}

Resolve conflicts by keeping W7 locale, offline and accessibility work alongside upstream time-zone, search, notifications, flags, SSE and mock-API changes. Point tests at the shared MSW server with hanging handlers for timeout coverage.

- Fix heading order on /patient/health (h1 -> h2 for section titles) - Update visual regression baselines for desktop and mobile

- Use waitFor() in LoginForm/SignupForm a11y tests to wait for async focus effect - The focus management runs in useEffect (async), tests now properly wait

github-actions · 2026-10-25T18:01:14Z

@Queen-T16 This PR now has merge conflicts with main, most likely because #157 (feat(platform): complete W7 API client, errors, PWA, and i18n) was just merged, so it can't be merged until it's rebased:

git fetch upstream            # upstream = https://github.com/DocForum/docforum-web.git
git rebase upstream/main
# resolve the conflicts, re-run the tests, then:
git push --force-with-lease

The usual culprits are shared docs like ROADMAP.md and ARCHITECTURE*.md. If the conflict is in the ROADMAP.md changelog, move your entry into a new file under changelog.d/ (see changelog.d/README.md) rather than resolving it in place, so it can't conflict again. CI re-runs when you push, and the needs-rebase label is removed automatically once the conflicts are resolved.

_{Automated message. It won't repeat unless the PR conflicts again after your next push.}

Queen-T16 force-pushed the feat/w7-platform-quality-consolidated branch from 8cd3e49 to c33dd98 Compare October 18, 2026 22:43

Queen-T16 added 2 commits October 18, 2026 23:11

feat(network): poor-network resilience: offline detection, retry poli…

e2bbc19

…cy, and safe mutation retries

fix(a11y): resolve pre-existing test failure in AdminDashboardPage lo…

d898796

…okup loading state - Closes DocForum#90

Queen-T16 force-pushed the feat/w7-platform-quality-consolidated branch 3 times, most recently from 6cddf7e to d898796 Compare October 18, 2026 23:14

Merge branch 'main' into feat/w7-platform-quality-consolidated

4bda10f

Merge branch 'main' into feat/w7-platform-quality-consolidated

53011b2

github-actions Bot added the needs-rebase Has merge conflicts with main; the author needs to rebase label Oct 20, 2026

github-actions Bot added needs-rebase Has merge conflicts with main; the author needs to rebase and removed needs-rebase Has merge conflicts with main; the author needs to rebase labels Oct 22, 2026

Queen-T16 added 2 commits October 24, 2026 19:02

Queen-T16 added 2 commits October 24, 2026 19:20

fix: add MSW test server and mocks to resolve CI failures

b43350c

Queen-T16 added 2 commits October 25, 2026 08:09

fix(tests): add hanging MSW handlers for timeout tests

4ebbc63

github-actions Bot removed the needs-rebase Has merge conflicts with main; the author needs to rebase label Oct 25, 2026

Queen-T16 added 2 commits October 25, 2026 17:28

fix: resolve CI e2e failures

1c88e36

- Fix heading order on /patient/health (h1 -> h2 for section titles) - Update visual regression baselines for desktop and mobile

fix: resolve act() warnings and focus tests in auth forms

e82961b

- Use waitFor() in LoginForm/SignupForm a11y tests to wait for async focus effect - The focus management runs in useEffect (async), tests now properly wait

github-actions Bot added the needs-rebase Has merge conflicts with main; the author needs to rebase label Oct 25, 2026

Navigation Menu

Repository navigation

W7 platform quality: poor-network resilience, locale-aware formatting, and accessibility fixes - #151

W7 platform quality: poor-network resilience, locale-aware formatting, and accessibility fixes#151
Queen-T16 wants to merge 13 commits into
DocForum:mainfrom
Queen-T16:feat/w7-platform-quality-consolidated

Queen-T16 commented Oct 18, 2026 •

edited

Loading

Uh oh!

drips-wave Bot commented Oct 18, 2026

Uh oh!

afeezorobsco-cyber commented Oct 19, 2026

Uh oh!

afeezorobsco-cyber commented Oct 20, 2026

Uh oh!

github-actions Bot commented Oct 20, 2026

Uh oh!

github-actions Bot commented Oct 22, 2026

Uh oh!

afeezorobsco-cyber commented Oct 22, 2026

Uh oh!

afeezorobsco-cyber commented Oct 24, 2026

Uh oh!

github-actions Bot commented Oct 24, 2026

Uh oh!

github-actions Bot commented Oct 25, 2026

Uh oh!

This branch has not been deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

Queen-T16 commented Oct 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

drips-wave Bot commented Oct 18, 2026

Uh oh!

afeezorobsco-cyber commented Oct 19, 2026

Uh oh!

afeezorobsco-cyber commented Oct 20, 2026

Uh oh!

github-actions Bot commented Oct 20, 2026

Uh oh!

github-actions Bot commented Oct 22, 2026

Uh oh!

afeezorobsco-cyber commented Oct 22, 2026

Uh oh!

afeezorobsco-cyber commented Oct 24, 2026

Uh oh!

github-actions Bot commented Oct 24, 2026

Uh oh!

github-actions Bot commented Oct 25, 2026

Uh oh!

This branch has not been deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Queen-T16 commented Oct 18, 2026 •

edited

Loading