Skip to content

feat(w7): data table, print/PDF, analytics, router migration (#116 #1… - #184

Merged
afeezorobsco-cyber merged 1 commit into
DocForum:mainfrom
Manager-dev1515:feat/w7-data-table-print-analytics-router
Oct 21, 2026
Merged

afeezorobsco-cyber merged 1 commit into
DocForum:mainfrom
Manager-dev1515:feat/w7-data-table-print-analytics-router

Conversation

@Manager-dev1515

Copy link
Copy Markdown
Contributor

…17 #118 #119)

Implements four W7 platform-quality issues:

closes #116 DataTable: generic DataTable with column definitions, server-side sort (aria-sort, scope=col), text/select filters, cursor pagination (Newer/Older, no page-number jump). useTableUrlState syncs sort/filters/cursor to URL. Responsive card layout under 600px. CSF 3 stories. 15 component + 7 hook tests.

closes #117 Print/PDF: PrintLayout component (logo, title, generated date, no nav chrome). usePrint hook (window.print + lazy jspdf/html2canvas PDF export, never in main bundle). PaymentReceiptDocument, OrderDetailDocument, DataExportSummaryDocument. @media print page-break rules.

closes #118 Analytics: src/utils/analytics.ts (cookieless, self-hostable, disabled unless VITE_ANALYTICS_ENDPOINT set). Explicit ALLOWED_EVENTS allowlist with no PHI. scrubUrl strips ids/query strings. DNT/GPC respected. useAnalyticsPageview for route tracking. /privacy page. .env.example updated.

closes #119 Router: docs/adr/0001-routing-strategy.md. BrowserRouter default, HashRouter when VITE_USE_HASH_ROUTER=true. deploy-pages.yml sets flag for GitHub Pages. HashRedirectShim redirects old #/path links. ARCHITECTURE_ESSENTIALS.md Deployment + Known assumptions updated.

typecheck: clean. build: OK. check:dist: no mock code in bundle. 50 new tests pass.

What changed

Which ROADMAP.md item does this close/progress?

(required — see AGENTS.md doc-update rules)

Docs updated in this PR (check all that apply)

  • ROADMAP.md
  • ARCHITECTURE.md
  • ARCHITECTURE_ESSENTIALS.md
  • PRD.md
  • N/A for this change

@github-actions

github-actions Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Malware scan: passed, with notes for the reviewer

Nothing malicious was detected in 61cfeda. These changes touch sensitive areas and should get a careful look before CI is approved:

Where Rule Why
.github/workflows/deploy-pages.yml:40 workflow-change Changes a CI workflow; a maintainer must review before approving runs.

@afeezorobsco-cyber

Copy link
Copy Markdown
Contributor

@Manager-dev1515 Thanks for the PR. The malware scan passed, and the only reviewer note is the expected one-line VITE_USE_HASH_ROUTER change in deploy-pages.yml. But the PR has merge conflicts with main: several web PRs merged today (#164, #171, #172, #173, #174), and #174 restructured the layout and navigation. Please rebase:

git fetch upstream
git rebase upstream/main
# resolve the conflicts (likely src/App.tsx, src/main.tsx, src/components/Layout.tsx,
# package.json / package-lock.json, ROADMAP.md, ARCHITECTURE_ESSENTIALS.md), then:
npm install && npm run typecheck && npm test && npm run build
git push --force-with-lease

Once it's conflict-free, CI will be approved, and if it's green it can be merged.

@Manager-dev1515
Manager-dev1515 force-pushed the feat/w7-data-table-print-analytics-router branch from 6faca35 to 4ec48c9 Compare October 20, 2026 11:19
@drips-wave

drips-wave Bot commented Oct 20, 2026

Copy link
Copy Markdown

@Manager-dev1515 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@github-actions github-actions Bot added the needs-rebase Has merge conflicts with main; the author needs to rebase label Oct 20, 2026
@github-actions

Copy link
Copy Markdown

@Manager-dev1515 This PR now has merge conflicts with main, most likely because #185 (Implement patient orders, doctor intake/consultation, and facility fulfillment flows (#5-#8)) was just merged, so it can't be merged until it's rebased:

git fetch upstream            # upstream = https://github.com/DocForum/docforum-web.git
git rebase upstream/main
# resolve the conflicts, re-run the tests, then:
git push --force-with-lease

The usual culprits are shared files like ROADMAP.md and ARCHITECTURE*.md. CI re-runs when you push, and the needs-rebase label is removed automatically once the conflicts are resolved.

Automated message. It won't repeat unless the PR conflicts again after your next push.

@Manager-dev1515
Manager-dev1515 force-pushed the feat/w7-data-table-print-analytics-router branch from 4ec48c9 to 9fdc36b Compare October 20, 2026 12:36
@github-actions

Copy link
Copy Markdown

@Manager-dev1515 This PR now has merge conflicts with main, most likely because #186 (feat(admin): fulfilment disputes queue for admins) was just merged, so it can't be merged until it's rebased:

git fetch upstream            # upstream = https://github.com/DocForum/docforum-web.git
git rebase upstream/main
# resolve the conflicts, re-run the tests, then:
git push --force-with-lease

The usual culprits are shared files like ROADMAP.md and ARCHITECTURE*.md. CI re-runs when you push, and the needs-rebase label is removed automatically once the conflicts are resolved.

Automated message. It won't repeat unless the PR conflicts again after your next push.

@Manager-dev1515
Manager-dev1515 force-pushed the feat/w7-data-table-print-analytics-router branch 2 times, most recently from caef720 to 952098d Compare October 20, 2026 16:06
@github-actions

Copy link
Copy Markdown

@Manager-dev1515 This PR now has merge conflicts with main, most likely because #135 (feat(messaging): message attachments — upload with progress, preview and secure download (#23)) was just merged, so it can't be merged until it's rebased:

git fetch upstream            # upstream = https://github.com/DocForum/docforum-web.git
git rebase upstream/main
# resolve the conflicts, re-run the tests, then:
git push --force-with-lease

The usual culprits are shared files like ROADMAP.md and ARCHITECTURE*.md. CI re-runs when you push, and the needs-rebase label is removed automatically once the conflicts are resolved.

Automated message. It won't repeat unless the PR conflicts again after your next push.

@Manager-dev1515
Manager-dev1515 force-pushed the feat/w7-data-table-print-analytics-router branch from 952098d to 3530504 Compare October 21, 2026 03:58
@github-actions github-actions Bot added needs-rebase Has merge conflicts with main; the author needs to rebase and removed needs-rebase Has merge conflicts with main; the author needs to rebase labels Oct 21, 2026
@github-actions

Copy link
Copy Markdown

@Manager-dev1515 This PR now has merge conflicts with main, most likely because #131 (feat(patient): order detail with a verifiable QR code and print-friendly view) was just merged, so it can't be merged until it's rebased:

git fetch upstream            # upstream = https://github.com/DocForum/docforum-web.git
git rebase upstream/main
# resolve the conflicts, re-run the tests, then:
git push --force-with-lease

The usual culprits are shared docs like ROADMAP.md and ARCHITECTURE*.md. If the conflict is in the ROADMAP.md changelog, move your entry into a new file under changelog.d/ (see changelog.d/README.md) rather than resolving it in place, so it can't conflict again. CI re-runs when you push, and the needs-rebase label is removed automatically once the conflicts are resolved.

Automated message. It won't repeat unless the PR conflicts again after your next push.

@Manager-dev1515
Manager-dev1515 force-pushed the feat/w7-data-table-print-analytics-router branch from 3530504 to 61cfeda Compare October 21, 2026 09:06
…m#116 DocForum#117 DocForum#118 DocForum#119)

Implements four W7 platform-quality issues:

typecheck: clean. build: OK. check:dist: no mock code in bundle. 50 new tests pass.
@github-actions github-actions Bot removed the needs-rebase Has merge conflicts with main; the author needs to rebase label Oct 21, 2026
@afeezorobsco-cyber
afeezorobsco-cyber merged commit 3631b84 into DocForum:main Oct 21, 2026
2 checks passed
freebuff-web Bot pushed a commit to Rafiat30/docforum-web that referenced this pull request Oct 24, 2026
…search-with-autocomplete

Resolve conflicts against upstream main (DocForum#156, DocForum#163, DocForum#184, DocForum#185, DocForum#208 and
follow-ups): keep both sides in models/fixtures/handlers/ROADMAP/
ARCHITECTURE_ESSENTIALS, keep the resilient mock-worker bootstrap, and
re-apply the PR's Find-a-doctor nav link, dashboard link and /patient/search
route on top of upstream's responsive-layout and care-hub rewrites.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

3 participants