Repository navigation
feat(w7): data table, print/PDF, analytics, router migration (#116 #1… - #184
Conversation
Malware scan: passed, with notes for the reviewerNothing malicious was detected in
|
|
@Manager-dev1515 Thanks for the PR. The malware scan passed, and the only reviewer note is the expected one-line git fetch upstream
git rebase upstream/main
# resolve the conflicts (likely src/App.tsx, src/main.tsx, src/components/Layout.tsx,
# package.json / package-lock.json, ROADMAP.md, ARCHITECTURE_ESSENTIALS.md), then:
npm install && npm run typecheck && npm test && npm run build
git push --force-with-leaseOnce it's conflict-free, CI will be approved, and if it's green it can be merged. |
6faca35 to
4ec48c9
Compare
|
@Manager-dev1515 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
|
@Manager-dev1515 This PR now has merge conflicts with git fetch upstream # upstream = https://github.com/DocForum/docforum-web.git
git rebase upstream/main
# resolve the conflicts, re-run the tests, then:
git push --force-with-leaseThe usual culprits are shared files like Automated message. It won't repeat unless the PR conflicts again after your next push. |
4ec48c9 to
9fdc36b
Compare
|
@Manager-dev1515 This PR now has merge conflicts with git fetch upstream # upstream = https://github.com/DocForum/docforum-web.git
git rebase upstream/main
# resolve the conflicts, re-run the tests, then:
git push --force-with-leaseThe usual culprits are shared files like Automated message. It won't repeat unless the PR conflicts again after your next push. |
caef720 to
952098d
Compare
|
@Manager-dev1515 This PR now has merge conflicts with git fetch upstream # upstream = https://github.com/DocForum/docforum-web.git
git rebase upstream/main
# resolve the conflicts, re-run the tests, then:
git push --force-with-leaseThe usual culprits are shared files like Automated message. It won't repeat unless the PR conflicts again after your next push. |
952098d to
3530504
Compare
|
@Manager-dev1515 This PR now has merge conflicts with git fetch upstream # upstream = https://github.com/DocForum/docforum-web.git
git rebase upstream/main
# resolve the conflicts, re-run the tests, then:
git push --force-with-leaseThe usual culprits are shared docs like Automated message. It won't repeat unless the PR conflicts again after your next push. |
3530504 to
61cfeda
Compare
…m#116 DocForum#117 DocForum#118 DocForum#119) Implements four W7 platform-quality issues: typecheck: clean. build: OK. check:dist: no mock code in bundle. 50 new tests pass.
…search-with-autocomplete Resolve conflicts against upstream main (DocForum#156, DocForum#163, DocForum#184, DocForum#185, DocForum#208 and follow-ups): keep both sides in models/fixtures/handlers/ROADMAP/ ARCHITECTURE_ESSENTIALS, keep the resilient mock-worker bootstrap, and re-apply the PR's Find-a-doctor nav link, dashboard link and /patient/search route on top of upstream's responsive-layout and care-hub rewrites.
…17 #118 #119)
Implements four W7 platform-quality issues:
closes #116 DataTable: generic DataTable with column definitions, server-side sort (aria-sort, scope=col), text/select filters, cursor pagination (Newer/Older, no page-number jump). useTableUrlState syncs sort/filters/cursor to URL. Responsive card layout under 600px. CSF 3 stories. 15 component + 7 hook tests.
closes #117 Print/PDF: PrintLayout component (logo, title, generated date, no nav chrome). usePrint hook (window.print + lazy jspdf/html2canvas PDF export, never in main bundle). PaymentReceiptDocument, OrderDetailDocument, DataExportSummaryDocument. @media print page-break rules.
closes #118 Analytics: src/utils/analytics.ts (cookieless, self-hostable, disabled unless VITE_ANALYTICS_ENDPOINT set). Explicit ALLOWED_EVENTS allowlist with no PHI. scrubUrl strips ids/query strings. DNT/GPC respected. useAnalyticsPageview for route tracking. /privacy page. .env.example updated.
closes #119 Router: docs/adr/0001-routing-strategy.md. BrowserRouter default, HashRouter when VITE_USE_HASH_ROUTER=true. deploy-pages.yml sets flag for GitHub Pages. HashRedirectShim redirects old #/path links. ARCHITECTURE_ESSENTIALS.md Deployment + Known assumptions updated.
typecheck: clean. build: OK. check:dist: no mock code in bundle. 50 new tests pass.
What changed
Which ROADMAP.md item does this close/progress?
(required — see AGENTS.md doc-update rules)
Docs updated in this PR (check all that apply)