[akinyemi07]

PR Summary

Overview

This PR implements Phase W2 patient core flow features addressing issues #2, #3, #4, and #31:

1. Booking & Structured Intake Form ([Phase W2] Booking + intake form #2):

   • Added BookingForm component in src/features/booking/ featuring time slot selection and structured intake fields (chiefComplaint, symptomDuration, severity, currentMedications, allergies, notes).
   • Explicitly handles 409 Conflict slot double-booking responses by alerting the patient that the slot was claimed and resetting slot selection for re-booking.

2. My Appointments List ([Phase W2] My appointments list #3):

   • Built AppointmentsList component in src/features/appointments/ reading GET /appointments/mine.
   • Displays scheduled/completed visits with doctor name, specialty, date, time, status, and empty state.

3. Referral Accept/Decline ([Phase W2] Referral accept/decline screen #4):

   • Implemented ReferralList in src/features/referrals/ displaying pending specialist referrals.
   • Accepts or declines referrals; accepting clearly confirms an appointment was auto-generated without requiring new intake entry.

4. Follow-Up Requests ([Phase W2] Follow-up requests: see and book follow-ups your doctor asked for #31):

   • Implemented FollowUpList in src/features/follow-ups/ displaying open follow-ups on the patient dashboard with doctor's notes and suggested windows.
   • Enables one-tap booking with an inline slot picker filtered to that doctor/window, prominently confirming that intake is carried over automatically from previous consultations.
   • Displays expired follow-up requests with rebooking options and handles empty states.

5. Infrastructure & Tests:

   • Added MSW mock fixtures and handlers covering all new endpoints (/appointments/mine, /doctors/:id/slots, POST /appointments, /referrals/pending, /referrals/:id/accept, /referrals/:id/decline, /follow-up-requests/mine, /follow-up-requests/:id/book).
   • Registered query keys in src/query-keys.ts and mutation invalidations in src/invalidations.ts.
   • Added route integration in PatientDashboardPage.tsx and 4 comprehensive unit test suites (78 test files, 660 tests passing total).
   • Documented assumed contracts in ARCHITECTURE_ESSENTIALS.md and updated ROADMAP.md Phase W2 checklist.

Closes #2, Closes #3, Closes #4, Closes #31

[github-actions]

@akinyemi07 This PR now has merge conflicts with main, most likely because #199 (feat(admin): per-specialty verification review for admins (Closes #65)) was just merged, so it can't be merged until it's rebased:

git fetch upstream            # upstream = https://github.com/DocForum/docforum-web.git
git rebase upstream/main
# resolve the conflicts, re-run the tests, then:
git push --force-with-lease

The usual culprits are shared docs like ROADMAP.md and ARCHITECTURE*.md. If the conflict is in the ROADMAP.md changelog, move your entry into a new file under changelog.d/ (see changelog.d/README.md) rather than resolving it in place, so it can't conflict again. CI re-runs when you push, and the needs-rebase label is removed automatically once the conflicts are resolved.

_{Automated message. It won't repeat unless the PR conflicts again after your next push.}

[drips-wave]

@akinyemi07 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

[afeezorobsco-cyber]

@akinyemi07 CI is failing on this branch against the latest main, so it can't be merged yet. The errors from the latest run:

Frontend (typecheck + test + build)

src/mocks/fixtures.ts(118,22): error TS2304: Cannot find name 'AvailabilitySlot'.
src/mocks/fixtures.ts(119,24): error TS2304: Cannot find name 'PatientAppointment'.
src/mocks/fixtures.ts(1463,5): error TS18004: No value exists in scope for the shorthand property 'pendingReferrals'. Either declare one or provide an initializer.
src/mocks/fixtures.ts(1464,5): error TS18004: No value exists in scope for the shorthand property 'followUpRequests'. Either declare one or provide an initializer.
src/mocks/fixtures.ts(1465,5): error TS18004: No value exists in scope for the shorthand property 'availabilitySlots'. Either declare one or provide an initializer.
src/mocks/fixtures.ts(1466,5): error TS18004: No value exists in scope for the shorthand property 'patientAppointments'. Either declare one or provide an initializer.
src/mocks/handlers.test.ts(559,27): error TS2304: Cannot find name 'referralService'.
src/mocks/handlers.test.ts(563,28): error TS2304: Cannot find name 'referralService'.

src/mocks/fixtures.ts, handlers.ts and handlers.test.ts reference names that no longer exist (AvailabilitySlot, PatientAppointment, pendingReferrals, referralService, patientCoreHandlers, and so on). Their definitions or imports were probably lost while resolving the rebase, so restore them from your earlier commits.

[github-actions]

Malware scan: passed, with notes for the reviewer

Nothing malicious was detected in 784e8b9. These changes touch sensitive areas and should get a careful look before CI is approved:

Where	Rule	Why
.github/workflows/deploy-pages.yml	workflow-change	Changes a CI workflow; a maintainer must review before approving runs.

[afeezorobsco-cyber]

@akinyemi07 This PR removes VITE_USE_HASH_ROUTER: "true" from .github/workflows/deploy-pages.yml. GitHub Pages has no server-side rewrites, so without the hash router every deep link (for example /docforum-web/patient/appointments) returns a 404 after deploy. CI won't catch this; it would only break the live site.

The PR doesn't add a 404.html SPA fallback either, so I think the line was lost while resolving a conflict. Please restore those three lines (the comment and VITE_USE_HASH_ROUTER: "true") and push. I'm holding this PR out of the automatic merge until then.

[github-actions]

@akinyemi07 This PR now has merge conflicts with main, most likely because #207 (feat(facility): API keys and webhooks management for facility system integrations (#55)) was just merged, so it can't be merged until it's rebased:

git fetch upstream            # upstream = https://github.com/DocForum/docforum-web.git
git rebase upstream/main
# resolve the conflicts, re-run the tests, then:
git push --force-with-lease

The usual culprits are shared docs like ROADMAP.md and ARCHITECTURE*.md. If the conflict is in the ROADMAP.md changelog, move your entry into a new file under changelog.d/ (see changelog.d/README.md) rather than resolving it in place, so it can't conflict again. CI re-runs when you push, and the needs-rebase label is removed automatically once the conflicts are resolved.

_{Automated message. It won't repeat unless the PR conflicts again after your next push.}

[afeezorobsco-cyber]

@akinyemi07 This PR now also reverts maintainer security tooling, which looks like it came from regenerating the tree from an older snapshot (commit 784e8b9):

• .github/scripts/pr-malware-scan.cjs: deletes the known-payload and script-hijack rules and loosens the off-screen-code check
• .github/scripts/pr-conflict-notifier.cjs: drops the changelog.d/ guidance
• .github/workflows/deploy-pages.yml: still removes VITE_USE_HASH_ROUTER (see my earlier comment)
• package.json: removes html2canvas, jspdf and qrcode, which main uses

Please rebase onto current main and make sure the PR only touches the files for your feature (git checkout origin/main -- .github package.json and then re-add only your own dependencies). The PR is on hold and CI won't be approved until the changes to .github/ are gone.

[afeezorobsco-cyber]

@akinyemi07 Closing this PR because it changes .github/scripts/pr-malware-scan.cjs and removes scanner rules, along with changes to the conflict notifier and deploy-pages.yml. This looks like an accidental side effect of a google-labs-jules[bot] commit regenerating files from an old snapshot, but we cannot keep a PR open that removes scanner rules, and it has not changed since fixes were requested. You are welcome to open a new PR from a fresh branch based on current main, containing only the feature changes.