Repository navigation
Close three text gaps left after #80 #81
Copy link
Copy link
Closed
Labels
Description
Goal
Close three text gaps that remain in the plan-lifecycle plugin after #80: the yolo temporary-worktree teardown, the red baseline after a review fix changes a spec test, and the contract advice list for an empty Research section.
Mode: plan-and-implement
Research
Repository facts (paths relative to the repository root):
plugins/plan-lifecycle/skills/productivity/yolo/SKILL.md, Commits item 2, ends the temporary worktree recipe withgit worktree remove -- <path>. Landing step 9 continues withgit worktree prune, and the rootAGENTS.mdsays: "Teardown isgit worktree removefollowed bygit worktree prune; removing the directory by hand leaves an orphan admin record."- Same file, Red baseline item 4: "When a spec test is wrong, record the reason in Verification Results, fix the test, and run the baseline again." It does not say whether this applies to a review fix, or which line to record. In the Close yolo, contract, and helper gaps from #78 #79 trial, a code-review fix changed a spec assertion, and the run wrote no new
Red baselineline. The run quotedtdd-workflow: "Test assertions are read-only during Phases 3–5", and that skill says to escalate a wrong test to the user. plugins/docks/skills/engineering/tdd-workflow/SKILL.md(Phase 2): "A test that passes prematurely is broken - fix the test, then re-run." (Rules): "If a test is wrong ... STOP and escalate to the user."plugins/plan-lifecycle/skills/productivity/plan-manager/references/plan-contract.md, advice paragraph: "a Research section that holds only_Not researched yet._after drafting". The helper (plan.mjs,researchFilledandprintAdvice) also prints that advice for an empty Research section. The Close yolo, contract, and helper gaps from #78 #79 code review reported this mismatch as LOW.node scripts/skills/content-hash.mjs --backfill plugins/plan-lifecycle/skillsrefreshescontent_hashinyolo/SKILL.mdandplan-manager/SKILL.md.
Decisions:
- Worktree teardown: add
git worktree pruneaftergit worktree removein Commits item 2. Rejected: leaving it to Landing, because Commits item 2 runs earlier and in a loop. - Review fix that changes a spec test: Red baseline item 4 applies to it. Run the changed test against the code before the fix; it must fail on the changed assertion. Record
Red baseline, step <id>, review round <k>: <command>: <k> failed, <m> passed. The yolo invocation answers the user escalation thattdd-workflowasks for; the record replaces it. Rejected: escalate to the user, because a yolo run asks only the merge question. - Contract advice: say "a Research section that is empty or holds only" the placeholder. Rejected: change the helper to skip empty Research, because the status gate already refuses empty Research, and the advice should match the gate.
- Release: a patch, after the merge, because only text changes.
Steps
| # | Id | Task | Files | Depends | Effect | Status | Done when |
|---|---|---|---|---|---|---|---|
| 1 | yolo_text | Add worktree prune to Commits item 2 and the review-fix red baseline rule to Red baseline item 4 | plugins/plan-lifecycle/skills/productivity/yolo/SKILL.md | - | local | done | both texts present; content hash refreshed; fresh agent answer recorded; plugin gate green; committed |
| 2 | contract_advice | Name empty Research in the contract advice list | plugins/plan-lifecycle/skills/productivity/plan-manager/references/plan-contract.md, plugins/plan-lifecycle/skills/productivity/plan-manager/SKILL.md | 1 | local | done | advice phrase names empty Research; content hash refreshed; plugin gate green; committed |
| 3 | release | Release plan-lifecycle as a patch after the landing merge | - | 2 | release | done | release tag exists, or the user declined and the step is skipped |
Acceptance
| ID | Command | Expected |
|---|---|---|
| A1 | node scripts/ci.mjs --plugin plan-lifecycle per commit and on the reviewed head |
Exit 0 |
| A2 | grep -n "git worktree prune" plugins/plan-lifecycle/skills/productivity/yolo/SKILL.md |
Two lines: Commits item 2 and Landing step 9 |
| A3 | A fresh read-only agent reads the new yolo text and gets the #79 trial situation: a code-review fix changes a spec assertion | It answers that the run records the reason, runs the changed test against the code before the fix, and adds a Red baseline, step <id>, review round <k> line, and it names no conflict with tdd-workflow |
| A4 | grep -n "is empty or holds only" plugins/plan-lifecycle/skills/productivity/plan-manager/references/plan-contract.md |
One line in the advice paragraph |
Do not touch
Plugin manifest and marketplace version fields (scripts/release.mjs bumps them after the merge). plan.mjs behavior. Skills of the docks plugin.
Open questions
Verification Results
- A1:
node scripts/ci.mjs --plugin plan-lifecyclepassed on each commit (1436679e,260302ab). - A2:
grep -n "git worktree prune"on yoloSKILL.mdprints two lines: Commits item 2 and Landing step 9. - A3: a fresh read-only agent answered: "The review fix changes a spec assertion, so yolo Red baseline item 5 applies ... Run the changed test against the code before the fix. It must fail on that assertion" and "Yolo item 4 replaces that step on purpose: "This record replaces the user escalation that
tdd-workflowasks for."" It found that the line format used<k>for both the round and the failed count. The committed text usesreview round <r>. - A4:
grep -n "is empty or holds only"onplan-contract.mdprints one line in the advice paragraph.
Reactions are currently unavailable
Activity
DocksDocks commentedon Oct 19, 2026
Plan review round 1
Plan-review: pass
None.
DocksDocks commentedon Oct 19, 2026
Code review round 1
Code-review: pass
Standards
<command>: passed before the fixwith the reason in Verification Results.Spec
None.
docs(plan-lifecycle): add worktree prune and the review-fix red baseline
docs(plan-lifecycle): name empty Research in the contract advice list