Skip to content

fix(ci): ootb@72e24e7 npm install 崩溃 — 清悬空 lock + registry/unzip 契约对齐#17

Merged
Tanya7z merged 2 commits into
mainfrom
cursor/bc-aa793122-0940-4680-8f6e-dd7a52061892-b926
Jul 22, 2026
Merged

fix(ci): ootb@72e24e7 npm install 崩溃 — 清悬空 lock + registry/unzip 契约对齐#17
Tanya7z merged 2 commits into
mainfrom
cursor/bc-aa793122-0940-4680-8f6e-dd7a52061892-b926

Conversation

@cursor

@cursor cursor Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Summary

触发:workflow_run ootb failure @ 72e24e7(run 29897268620)—— Install root depsCannot read properties of undefined (reading 'extraneous')

e6525bb(tools → .mjs + tools/lib)已覆盖空 catalog / catalog-sync 等,但 未清 package-lock.json 悬空 workspace link,且 sfmc/src/registry.ts 仍把整份 index 当映射(未读 modules 嵌套)。

本 PR 取代 #15/#16 的 CI 关键修复(二者已与 e6525bb/72e24e7 冲突)。

根因与修复(SOLID)

级别 原则 问题 修复
BLOCKER DRY lock 仍 link 已删 modules/packages/* 清理并 regen,保留 fixture afk
BLOCKER LSP unzip 未归一 Windows \\ → Linux 目录错乱 fetch-module 路径 / 归一化
MAJOR DRY/LSP registry.tsfetch-module 对同一 index 契约不一致 parseRegistryIndexmodules
MINOR DRY folderFromEntry 重复 / packages 双文件头 复用 folderFromEntryPath

验证

  • npm install
  • node tools/check-ootb.mjs10/10
  • node tools/smoke-modules.mjs(含 feature-afk 启停翻转)✅
  • unzip 反斜杠路径单测 ✅

不重复 #13/#14 的 economy SQL / service 权限门改动。

Open in Web View Automation 

cursoragent and others added 2 commits July 22, 2026 06:41
ootb@72e24e7 在 npm install 因 package-lock 残留已删 modules/packages/*
的 link:true 崩溃。同步修复 registry 解析 modules 嵌套、zip 反斜杠路径归一化,
并去重 catalog folder 解析(DRY/LSP)。

Co-authored-by: Shiroha <Tanya7z@users.noreply.github.com>
合并并行审查 #18 的补充:单一 parseRegistryIndex 源、fetch-module 显式依赖 jszip,
以及 module-commands dirSize 未 await 导致体积恒 0。

Co-authored-by: Shiroha <Tanya7z@users.noreply.github.com>
@cursor

cursor Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor Author

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

@Tanya7z
Tanya7z merged commit 522d799 into main Jul 22, 2026
1 check passed
@Tanya7z
Tanya7z deleted the cursor/bc-aa793122-0940-4680-8f6e-dd7a52061892-b926 branch July 22, 2026 06:47
Tanya7z added a commit that referenced this pull request Jul 22, 2026
Rebased onto main@522d799 (post #17). Platform/SDK only: config client withModuleId; service routes assertModulePermission; review doc.

Co-authored-by: Cursor <cursoragent@cursor.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants