fix(solid): sql-helpers + tx requires 单点 + npm-publish DRY(取代 #20)#21
Merged
Tanya7z merged 1 commit intoJul 22, 2026
Merged
Conversation
审查 main@2dbb079(@sfmc-bds 发包)后的跟进补丁,覆盖并取代 #20: - DRY: economy 本地 sql() → sql-helpers;HttpDB.withModuleId 统一三抽屉 - DRY/LSP: tx.doService 去掉重复 requires 预检,错误码走 DispatchError - DRY: npm-publish 包清单抽到 tools/lib/npm-publish-packages.mjs - CI: npm-publish Node 对齐 ootb 的 22.22;SDK engines ≥22.13 Co-authored-by: Shiroha <Tanya7z@users.noreply.github.com>
3 tasks
Tanya7z
marked this pull request as ready for review
July 22, 2026 12:22
Contributor
Author
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
Contributor
Author
There was a problem hiding this comment.
Push 审查 — merge #21 → main@6e08f50
ootb:绿(run 29919341042)。#21 的 sql-helpers / tx requires 单点 / withModuleId / npm-publish DRY 落地正确,无回退 BLOCKER。
本轮仍发现的高置信度项 → 已开跟进 PR
| 级别 | 原则 | 项 |
|---|---|---|
| MAJOR | LSP | HttpDB.typedRequest 对 HTTP 200+{success:false} 误判成功 |
| MAJOR | LSP | service 路由成功 ok / 失败 success 方言分裂 |
| MINOR | LoD/DRY | req.moduleAuth 私有字段 + 三处重复读取 |
| MINOR | — | AGENTS.md 过时 FROM ? 说法 |
跟进补丁:后续 automation PR(标题含「HTTP 信封 LSP + moduleAuth 经 ctx」)。
刻意未动(需 Stage-F / 协议设计)
- DIP: host token 注入
- LSP:
db.tx录制器 - OCP: economy handler 硬编码接线
Sent by Cursor Automation: SFMC-Review
4 tasks
Tanya7z
added a commit
that referenced
this pull request
Jul 22, 2026
…b43a-fefb699df606-1b11 fix(solid): HTTP 信封 LSP + moduleAuth 经 ctx(#21 跟进)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
审查 main push
2dbb079(pubulish:sdk,db,qq,cil,bds-tools:@sfmc→@sfmc-bds发包)后的 DRY · OCP · DIP · LSP · LoD 跟进补丁。package.json冲突,本 PR 在当前 main 上重放并扩展其修复 → 请关闭 fix(solid): sql-helpers 权威入口 + tx requires 单点 + withModuleId DRY #20审查发现 → 已修
sql()与未使用且易误用的raw()并存sql()提升为sql-helpers权威入口;测试钉死 raw 插值脚枪TxRunner.doService重复 requires 预检;未注册服务在 tx 误报not_in_requiresServiceRegistry.dispatch;DispatchError透传withModuleIdHttpDB.withModuleId(path, moduleId)npm-publish.yml里 bashcase+ JSmap双份包清单;文档还声称 module tag 也会走 CItools/lib/npm-publish-packages.mjs+resolve-npm-publish-tag.mjs;文档对齐npm-publish钉 Node 22.13,与 ootb(22.22 / npm-run-all2)漂移,tag 发布易踩 EBADENGINEengines≥22.13npm test找不存在的src/*.test.jsbuild && node --test dist/*.test.js仍未修(已知债)
HttpDB.authTokendb.tx录制器语义;响应信封okvssuccessindex.ts硬编码接线req.moduleAuth私有字段Test plan
cd db-server && npm test(6/6)SFMC_ROOT=$PWD node tools/check-ootb.mjs(10/10)GITHUB_REF_NAME='@sfmc-bds/sdk@v0.1.0' node tools/resolve-npm-publish-tag.mjs