Repository navigation
Report a workflow it could not read as unknown, not as pinned - #12
Merged
Merged
Conversation
The check merged an hour ago returned an empty list when a request failed, so a single dropped call reported a repository with twenty-one loose references as fully pinned. That happened on its first real use: a sweep across the nine repositories skipped decisionrl silently, and three immediate retries all returned twenty-one, so the failure was one blip rather than anything persistent. This file's docstring already states the rule I broke -- a repository that could not be read is listed as unread, never silently counted as quiet -- and I broke it in the check added to enforce a different one. unpinned_actions now returns None for unreadable and never an empty list in that case, and the report says the pinning is unknown rather than fine. Three attempts before giving up, because a truthful check that cries wolf on every dropped packet becomes weekly noise, and noise is how a report stops being read.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #11, which shipped the unpinned-actions check an hour ago.
It returned
[]when a request failed, so a dropped call reported a repository as fully pinned. That happened on its first real use — a sweep across all nine repositories silently skipped decisionrl, which has 21 loose references; three immediate retries all returned 21, so the failure was one blip.This file's own docstring states the rule: a repository that could not be read is listed as unread, never silently counted as quiet. I broke it in the check added to enforce another one.
Now:
unpinned_actionsreturnsNonefor unreadable and never[], the report says the pinning is unknown rather than fine, and there are three attempts before giving up — a truthful check that cries wolf on every dropped packet becomes noise, and noise is how a report stops being read.Verified both paths: normal run reports 21 for decisionrl and 0 elsewhere; with every call stubbed to fail it returns
Nonerather than an empty list.