Repository navigation
Report a pull request that is green and waiting on a decision - #14
Merged
Merged
Conversation
The report answers one question -- what needs a decision this week -- and could
not see the clearest case of all. A pull request whose checks are green, which
is not a draft and was not opened by a bot, has had everything done to it that
can be done automatically. The only thing left is somebody deciding. That is
the question, and it was falling through.
It fell through because red checks were the only thing that counted as needing
you, and thirty days the only thing that counted as old. decisionrl#31 is green
on every leg including the forty-minute learning job, has been open for
twenty-four days, and the report called the repository quiet.
Adding the section finds four of them immediately, none of which the report has
ever mentioned:
decisionrl#31 green 24 days the ignore filter that does not filter
decisionrl#24 green 24 days off-policy evaluation for contextual bandits
decisionrl#22 green 24 days seeded rollout-buffer RNG and eval-freeze
stadion#4 green 40 days concurrent instances
The last would have appeared under Drifting on age alone, with nothing to say
it was ready.
"none" is what collect() reports when no check ever ran, which in a repository without CI is every pull request in it. This one had none until yesterday, and #7 -- adding stadion to the organisation profile, twenty-eight added lines and nothing removed -- has been cleanly mergeable there for forty-one days without appearing in a single report. It is labelled differently from green, because "no checks ran" and "checks passed" are not the same news and the line should not pretend otherwise.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The triage answers one question — what needs a decision this week — and could not see the clearest case of all.
A PR that is green (or has no checks at all), is not a draft, and was not opened by a bot has had everything done to it that can be done automatically. What is left is somebody deciding. It fell through because red checks were the only thing that counted as needing you, and thirty days the only thing that counted as old.
Running it with the section added finds six, none of which the report has ever mentioned:
stadion#4would have shown under Drifting on age alone, with nothing to say it was ready..github#7showed nowhere: this repository had no CI until yesterday, so every PR in it reportsnone, andnonewas notred.No checks ran is labelled differently from green, because they are not the same news.
The exit code now reports non-zero when only this section is populated, so a week whose sole news is "five finished things are waiting for you" still raises the issue.