Repository navigation
Adding setting/getting seed for MOIRE - #51
Merged
Merged
Conversation
…was used is reported either way so if a run fails or produces an odd results this can be reproduced
NULL seeds now leave room for per-chain offsets, and tempering swaps draw from the C++ sampler instead of R's RNG.
Child RNG offsets now live in src/seed.h, and examples/NEWS describe the seed that is actually used.
A fixed stride of 1000 silently overlapped streams once a temperature ladder reached that length.
The default constructor only existed so vector<Chain> could resize, and it pulled in random_device plus dead engines.
parallel::mclapply does not allow mc.cores > 1 there, so the num_cores comparison cannot run.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
run_mcmc(seed =)sets the sampler seed.NULLdraws from the current R RNG a value that still fits after per-chain offsets.The seed used is returned as
$seed(printed if the run errors). Per-chain offsets are$chain_seeds. A seed (ornum_chains) that cannot fit those offsets is rejected.Replay needs the same sampler settings;
num_coresdoes not affect the draws, because parallel-tempering swaps use the C++ sampler rather than R's RNG.