[m-murphy]

Summary

Stacked on #88. Turns on the checks that were loaded but off, and fixes what they found.

 ci:verify
   typecheck
+  lint
   build
+  unit tests (api + web)
   docs stale-claims check
+.github/workflows: Checks runs ci:verify on every PR
+pre-commit: lint staged API and web files

• Lint fixes: 30 API and 64 web no-unnecessary-condition errors. Where a guard exposed a type that lies about the wire, the type was fixed (a control source's definition and getSource's fields are optional; scan-move CSV cells can be missing).
• React hooks rules on: 86 problems. Four components returned before their hooks (CollectionMove, ControlBatchWizard, ReferenceData, StatChart), so a permission or tab change mid-session changed the hook count and React threw.
• Transactions: a lint rule rejects async callbacks passed to database.transaction, which commits at the callback's first await.
• Schema snapshot test: fails when initial_schema.sql falls behind schema.ts (the fresh-install gap behind a3bddaa).
• Agent docs: pointers to the package test and db READMEs, a trimmed domain doc, and .gitignore entries for local database copies and worktrees.

Evidence

• Before: bun run lint reported 94 no-unnecessary-condition errors and 86 hooks problems, and CI ran neither lint nor tests.
  After: bun run ci:verify passes locally: typecheck, lint, build, API and web tests, docs check.
• Before: snapshot test against the pre-a3bddaa initial_schema.sql → fails, reporting version 6 and the three missing qPCR tables.
  After: passes against the current snapshot.

Review follow-ups

• Hooks and effects: chart colors are read for the theme being rendered, so the three exhaustive-deps disables are gone. Effects in the batch wizard and ContainerRegistration rerun only on their original triggers. Box and bag sheet expansion is set up on load, not on every refetch.
• Shared code: WriteGuard gates CollectionMove and ControlBatchWizard; useCollectionSheets, defaultScannerConfiguration, one shared empty list, and insertedRow replace repeated code. Collection delete branches on every collection type explicitly.
• Transaction lint: a type-aware rule flags any transaction callback that returns a Promise, including named async functions, and now covers tests.
• Schema snapshot test: also compares types, NOT NULL, defaults, primary keys, indexes and foreign keys, and closes its database.
• CI and hooks: superseded Checks runs are cancelled only on pull requests, so back-to-back merges to main both run. Pre-commit refuses a staged source file that also has unstaged edits, since eslint's type-aware rules read the working-tree copy.
• Tests: scrollIntoView is stubbed in the web test setup instead of guarded in production code.
• Evidence: bun run ci:verify passes: API 1087, web 948, contract 86.

Merge Danger

Door: two-way

Blast Radius: wide-but-shallow

Touches 87 files, mostly type narrowing and memoization. The behavioural changes are the four hook-order fixes and effects moved to useEffectEvent, whose triggers are unchanged. Every PR will now fail CI on a lint error or failing test. Pre-commit now refuses partially staged API and web source files.

🤖 Generated with Claude Code