Skip to content

docs: add coding standards drawn from the ADRs - #92

Open
m-murphy wants to merge 1 commit into
docs/agents-md-restructurefrom
docs/adr-coding-standards
Open

m-murphy wants to merge 1 commit into
docs/agents-md-restructurefrom
docs/adr-coding-standards

Conversation

@m-murphy

@m-murphy m-murphy commented Oct 6, 2026

Copy link
Copy Markdown
Member

Summary

Adds the coding rules taken from the ADRs to CODING_STANDARDS.md. They were split out of #91 so each one can be reviewed before code-review starts enforcing it.

 ## API
 ### Database
+### Domain modules     registerSpecimens (0010), containerWriteInputSchema (0006),
+                       resolveSpecimenSource(s) (0007), loadContainerReadViews (0009)
+### Routes             wire DTOs + omitOnWireMiddleware (0005), typed errors (0004),
+                       observability / error-logger (0004)
 ### API tests
 ## Web
+  settingsApi (0002), .optional() Zod fields (0005), inline read errors (0001),
+  invalidating domain hooks (0001), scan-move core (0008)
 ### Web tests

Evidence

  • The subagent that wrote these rules checked every named symbol against the code and spot-checked current code for violations. It found none.
  • Review question for each rule: is it a standing rule, or only a description of how the code works today?

Merge Danger

Door: two-way

Blast Radius: code-review

Every rule here becomes something code-review flags. A rule that is too strict will produce noisy findings until it is removed.

🤖 Generated with Claude Code

Domain modules (ADRs 0006, 0007, 0009, 0010), routes (0004, 0005), and
web rules (0001, 0002, 0005, 0008), each citing its ADR so code review
can enforce it.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant