Skip to content

just bump leaves the lockfiles' own version entries behind #777

Closed

Description

@EVWorth

What's wrong

just bump [patch|minor|major] updates package.json, src-tauri/tauri.conf.json and src-tauri/Cargo.toml, but not the lockfile entries that record the app's own version:

  • package-lock.json: the root "version" and packages[""].version
  • src-tauri/Cargo.lock: the [[package]] name = "sqlpilot" entry

Every release PR so far (#751, #761, #771) has fixed those up afterwards, which the "never hand-edit a lockfile" rule says not to do. Left alone, the next npm install or cargo build rewrites them, and that change lands in an unrelated commit.

Fix

At the end of the bump recipe in justfile, regenerate the entries with the tools rather than sed:

npm install --package-lock-only --ignore-scripts
(cd src-tauri && cargo update -p sqlpilot --offline)

Then scripts/check-release-readiness.sh could also confirm both lockfiles carry the new version.

Found while moving the agent docs into CLAUDE.md (#775).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions