fix: default child timeout and validate AAS_GUI_PORT - #11
Merged
Conversation
Hung decide/act/prove children now fail closed after 30s
(AAS_CHILD_TIMEOUT_MS). Empty GUI port and timeout env values keep
the documented defaults instead of Number("")/NaN, and invalid
integers are rejected before a run starts.
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
| ...opts, | ||
| maxBuffer: CHILD_JSON_LIMIT, | ||
| ...rest, | ||
| timeout, |
There was a problem hiding this comment.
🔴 Child timeout can hang forever
When a child ignores SIGTERM, spawnSync keeps waiting after timeout expires. One hung stage can still block the entire run indefinitely.
Suggested change
| timeout, | |
| timeout, | |
| killSignal: "SIGKILL", |
Was this helpful? React with 👍 or 👎 to provide feedback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Apply env-backed defaults for child process timeouts and the local GUI port.
AAS_CHILD_TIMEOUT_MS), instead of hanging the run.AAS_GUI_PORT(default 8787) is parsed as an integer 1–65535. Empty/unset keeps the default;Number("")/NaNno longer bind a junk port.maxBufferis wired to the existingCHILD_JSON_LIMIT.Why
Theme 6 (config, env, and defaults): the GUI already read
AAS_GUI_PORTbut defaulted badly, and child tools had no timeout at all.How tested
npm test(42 passing, including env parsing, hung-child timeout, decide-timeout fail-closed, and invalid timeout before a demo run)npm run gui:smokenode --checkon the orchestrator, GUI, and bootstrap entrypoints