Parse logged multiline child JSON - #4
Merged
Conversation
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Comment on lines
+124
to
+127
| for (let start = 0; start < end; start += 1) { | ||
| if (!/^[\[{]/.test(lines[start].trim())) continue; | ||
| try { | ||
| return JSON.parse(line); | ||
| return JSON.parse(lines.slice(start, end).join("\n")); |
There was a problem hiding this comment.
🔴 Truncated evaluations can authorize actions
When outer JSON is truncated, parseJsonOutput accepts a complete nested object as the entire response. A nested passed: true can permit a refund despite an unreadable policy evaluation.
Prompt for agents
Update parseJsonOutput in bin/aas.mjs so logged output extraction recognizes complete top-level JSON documents rather than trying every line-delimited substring. It must reject a valid nested object or array when its enclosing document is truncated, while still supporting pretty-printed top-level objects and arrays, leading or trailing logs, and multiple complete values with the last value selected. Add regression tests for truncated outer objects and arrays that contain valid nested values, including a nested object with passed: true.
Was this helpful? React with 👍 or 👎 to provide feedback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tests