feat(color): add Slovakian 🇸🇰 translation - #6830
Conversation
|
Thanks for this... it needs a little more done to integrate it into EdgeTX proper, but you've done the hard work for us (the translation) :) I'll try and do the finishing bits next week. |
|
Thank you so much for this
Brano
Dňa pi, 5. dec 2025, 1:34 Peter Feerick ***@***.***>
napísal(a):
… *pfeerick* left a comment (EdgeTX/edgetx#6830)
<#6830 (comment)>
Thanks for this... it needs a little more done to integrate it into EdgeTX
proper, but you've done the hard work for us (the translation) :) I'll try
and do the finishing bits next week.
—
Reply to this email directly, view it on GitHub
<#6830 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AQADYRK6O4ZG6QZMTDKQQOT4ADHKRAVCNFSM6AAAAACNIUD6LSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTMMJUHA2TMOBUGM>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
d5e02d8 to
ddd0d5c
Compare
pfeerick
left a comment
There was a problem hiding this comment.
This looks mostly ok, and both firmware and simulator build now. For now, I'm focusing on colourlcd support, but work is needed on B&W still (for the accent symbols). Can you review/update the language strings I added the recent commits.
|
It looks like the translations use unicode characters; but the PR does not contain any B&W font files for the special characters. This will likely not work on B&W radios. |
📝 WalkthroughWalkthroughAdds Slovak localization across UI and bootloader strings, simulator language bundles, firmware language registration, build wiring, locale generation, and function sorting. Also corrects a Czech bootloader instruction wording. ChangesSlovak translation support
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant SlovakDefinitions
participant SimulatorBundle
participant TranslationRegistry
participant SorterTooling
SlovakDefinitions->>SimulatorBundle: provide Slovak TR_ definitions
SimulatorBundle->>TranslationRegistry: build skLangStrings
TranslationRegistry->>TranslationRegistry: register Slovak language tables
SorterTooling->>SorterTooling: compile Slovak locale and generate function ordering
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Description checkExplanation The description includes the required "Fixes #" and "Summary of changes" sections. The summary explains the Slovak translation work and related validation context. The issue reference is blank, but this is non-critical. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 6
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@radio/src/translations/bl_translations.h`:
- Line 425: Correct the TR_BL_NO_VERSION translation value from "Zadna verzia"
to the ASCII Slovak form "Ziadna verzia", preserving the existing macro name and
formatting.
In `@radio/src/translations/i18n/sk.h`:
- Line 77: Translate the TR_MAIN_RADIO_SETTINGS string into Slovak while
preserving the existing macro name and formatting.
- Around line 1434-1439: Translate the newly added shortcut strings in the
Slovak translation definitions, updating TR_KEY_SHORTCUTS, TR_CURRENT_SCREEN,
TR_SHORT_PRESS, TR_LONG_PRESS, TR_OPEN_QUICK_MENU, and TR_QUICK_MENU_FAVORITES
from English to Slovak while preserving their macro names and formatting.
- Line 645: Correct the color LCD translation in TR_PRESSANYKEY by changing
“Stač klávesu” to “Stlač klávesu”, while leaving the other translation
unchanged.
- Around line 1317-1327: Correct the Slovak language names in the TR_VOICE_*
definitions, especially the truncated Portuguese translation, and review the
adjacent entries for any other omitted letters. Use the standard Slovak
spellings while preserving each macro’s existing language mapping and
formatting.
- Line 1070: Update the TR_AFHDS3_POWER_SOURCE translation definition to remove
the redundant nested TR macro and provide the properly translated Slovak string
directly.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: ba059eae-ca22-4e5e-b059-e4f0c3e5db34
📒 Files selected for processing (9)
radio/src/CMakeLists.txtradio/src/cfn_sort.cppradio/src/translations/bl_translations.hradio/src/translations/i18n/sk.hradio/src/translations/sim/lang_sk.cppradio/src/translations/translations.cppradio/src/translations/translations.htools/cfn_sorter.cpptools/cfn_sorter.sh
7c3078f to
e40dea7
Compare
e40dea7 to
f5581fa
Compare
Adds full Slovak translations for firmware, bootloader, and simulator, plus custom function sorting tooling updates.
The committed Slovak custom-function sort order was stale relative to the current sk.h translation strings and not alphabetized like the other language blocks. Re-ran cfn_sorter.sh to bring it back in sync. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Every language relies on radio/src/tests/test_<lang>.cpp compiling against string_list.h to catch missing TR_* macros, but sk.h had no corresponding test file so Slovak was silently skipped by this check. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
isTextLangAvail() excluded LANG_SK for colorLCD, even though the Slovak string table (skLangStrings) already exists, so it never appeared in the Text language picker. Keep the exclusion for non-colorLCD (B&W) radios since those lack Unicode font support for Slovak diacritics. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
tools/cfn_sorter.sh needs sk_SK.UTF-8 generated to regenerate cfn_sort.cpp now that Slovak (SK) translations exist, but the Ubuntu setup scripts never generated it, so a contributor following the official build docs would hit a locale::facet runtime error. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
92640e5 to
8d63e88
Compare
Fixes #
Summary of changes:
Hello,
I make SLOVAK (SK) translation for EDGETX please check and input to the system..Many thanks for support
As the build environment now validates some aspects of language/translation PRs, EdgeTX/build-edgetx#53 has been created and merged in order to validate the cfn sort order.
Summary by CodeRabbit
sk) language support across the radio UI, simulator, and generated language packs.sk_SK.UTF-8and Slovak-specific function ordering.