Repository navigation
vulkan_device: decode the NVIDIA driver version for the vertex input dynamic state check - #893
Merged
rdenno merged 1 commit intoNov 22, 2026
Conversation
The check that disables VK_EXT_vertex_input_dynamic_state on NVIDIA drivers older than 580.119.02 compared driverVersion, with its top three bits cleared, against VK_MAKE_API_VERSION(580, 119, 2, 0). NVIDIA packs the version as 10.8.8.6 bits, so clearing three bits cut the major number to 7 bits and every driver compared as older: the extension was disabled on all NVIDIA drivers, and vertex layouts stayed part of the pipeline key. Decode major, minor and patch with NVIDIA's layout and compare those. On Hyrule Warriors (RTX 5060 Ti, 610.88, cold cache, same route) this builds 280-283 graphics pipelines instead of 338-340. Assisted-by: Gemini 3.8 Flash (fix), Claude Fable 5.2 (diagnosis and testing)
Contributor
Collaborator
|
Can test with the linux-cachyos-nvidia-open driver v620.70.06 |
azeselh
pushed a commit
to azeselh/Dalia
that referenced
this pull request
Nov 21, 2026
…mmunity#893) es.ts had none of the strings the nx2 frontend added that Transifex does not cover, so Spanish users saw those windows in English. Same approach as Eglantine-Community#827 for zh_CN. - 404 missing messages, 10 of them in contexts es.ts didn't have yet. - The 30 entries that were still unfinished. - Found with lupdate (Qt 6.11.1) over src/yuzu and src/qt_common, plus the NVIDIA DLSS panel's Tr() strings, which lupdate doesn't see. - Follows the terms and the formal "usted" es.ts already uses. Existing translations are unchanged; obsolete entries are left as they are. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
VK_EXT_vertex_input_dynamic_statewas disabled on every NVIDIA proprietary driver, not only the ones older than 580.119.02 that the check was written for. Vertex layouts therefore stayed part of the pipeline key, and games built many more pipelines than needed.driverVersionand compared the result withVK_MAKE_API_VERSION(580, 119, 2, 0). NVIDIA packs its version as 10.8.8.6 bits, so clearing three bits cut the major number to 7 bits and every driver compared as older. The log showsDisabling broken VK_EXT_vertex_input_dynamic_stateon driver 610.88.Built using Claude Fable 5.2 and Gemini 3.8 Flash
Type of change
Related issues
None
Testing
Games tested:
RTX 5060 Ti, driver 610.88, the same recorded input in every run,
vertex_input_dynamic_stateoff against on with this change (off is what every NVIDIA user gets today).Captured frames of both games look the same with the extension on. Frame rate does not change; the gain is fewer pipelines to build and to load at boot.
Limitations: only tested on one NVIDIA driver (610.88). I could not test the drivers older than 580.119.02 that the check exists for, so I can't say whether the original breakage is still real there; they stay disabled as intended. The Intel comparison in the same check uses
VK_MAKE_API_VERSIONagainst Intel's own version packing and may have the same kind of mistake; I have no Intel hardware and left it alone.Checklist
Screenshots / logs
Before, on driver 610.88:
After: the line is gone and the pipeline cache keys carry the dynamic vertex input flag.
Summary by CodeRabbit