Skip to content

vulkan_device: decode the NVIDIA driver version for the vertex input dynamic state check - #893

Merged
rdenno merged 1 commit into
Eglantine-Community:nx2-experimentalfrom
rdenno:fix/vk-nvidia-vids-version-exp
Nov 22, 2026
Merged

rdenno merged 1 commit into
Eglantine-Community:nx2-experimentalfrom
rdenno:fix/vk-nvidia-vids-version-exp

Conversation

@rdenno

@rdenno rdenno commented Nov 16, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

VK_EXT_vertex_input_dynamic_state was disabled on every NVIDIA proprietary driver, not only the ones older than 580.119.02 that the check was written for. Vertex layouts therefore stayed part of the pipeline key, and games built many more pipelines than needed.

  • Cause: the check cleared the top three bits of driverVersion and compared the result with VK_MAKE_API_VERSION(580, 119, 2, 0). NVIDIA packs its version as 10.8.8.6 bits, so clearing three bits cut the major number to 7 bits and every driver compared as older. The log shows Disabling broken VK_EXT_vertex_input_dynamic_state on driver 610.88.
  • Fix: decode major, minor and patch with NVIDIA's layout and compare those with 580.119.2. The Intel half of the check is unchanged.

Built using Claude Fable 5.2 and Gemini 3.8 Flash

Type of change

  • Bug fix
  • Game compatibility / game-support
  • Performance
  • New feature
  • Refactor / cleanup
  • CI / build
  • Documentation

Related issues

None

Testing

  • Tested on Windows
  • Tested on Linux
  • Tested on macOS
  • Tested on NVIDIA
  • Tested on AMD
  • Tested on Intel

Games tested:

RTX 5060 Ti, driver 610.88, the same recorded input in every run, vertex_input_dynamic_state off against on with this change (off is what every NVIDIA user gets today).

off on
Hyrule Warriors: Age of Imprisonment, graphics pipelines built from a cold cache 338, 340 280-283 (4 runs)
Hyrule Warriors, pipeline build time on the GPU thread, cold cache 2249, 2308 ms 1506-1685 ms
Hyrule Warriors, fight fps, warm cache, interleaved 48.7, 43.6, 43.0 47.9, 45.5, 46.7
Mario Kart World (Grand Prix), graphics pipelines from a cold cache 1533, 1500 1129, 1173
Mario Kart World, race fps 39.6-44.2 39.3-40.7

Captured frames of both games look the same with the extension on. Frame rate does not change; the gain is fewer pipelines to build and to load at boot.

Limitations: only tested on one NVIDIA driver (610.88). I could not test the drivers older than 580.119.02 that the check exists for, so I can't say whether the original breakage is still real there; they stay disabled as intended. The Intel comparison in the same check uses VK_MAKE_API_VERSION against Intel's own version packing and may have the same kind of mistake; I have no Intel hardware and left it alone.

Checklist

  • I built it locally and it compiles without new warnings
  • I did not add any copyrighted game data, keys or firmware
  • Docs updated if needed
  • I added AI Disclosure if one was used

Screenshots / logs

Before, on driver 610.88:

Render.Vulkan <Warning> vulkan_device.cpp:GetSuitability: Disabling broken VK_EXT_vertex_input_dynamic_state

After: the line is gone and the pipeline cache keys carry the dynamic vertex input flag.

Summary by CodeRabbit

  • Bug Fixes
    • Improved compatibility with NVIDIA drivers by refining how driver versions are evaluated for dynamic vertex input support.
    • Existing Intel Windows driver compatibility handling is unchanged.

The check that disables VK_EXT_vertex_input_dynamic_state on NVIDIA
drivers older than 580.119.02 compared driverVersion, with its top
three bits cleared, against VK_MAKE_API_VERSION(580, 119, 2, 0).
NVIDIA packs the version as 10.8.8.6 bits, so clearing three bits cut
the major number to 7 bits and every driver compared as older: the
extension was disabled on all NVIDIA drivers, and vertex layouts stayed
part of the pipeline key.

Decode major, minor and patch with NVIDIA's layout and compare those.
On Hyrule Warriors (RTX 5060 Ti, 610.88, cold cache, same route) this
builds 280-283 graphics pipelines instead of 338-340.

Assisted-by: Gemini 3.8 Flash (fix), Claude Fable 5.2 (diagnosis and testing)
@coderabbitai

coderabbitai Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The NVIDIA proprietary driver check for disabling VK_EXT_vertex_input_dynamic_state now compares decoded version components against 580.119.2. The Intel Windows comparison against 27.20.100.0 is unchanged.

Changes: Driver version check

Layer / File(s) Summary
Update NVIDIA version comparison
src/video_core/vulkan_common/vulkan_device.cpp
The workaround now compares NVIDIA driver major, minor, and patch components against 580.119.2 using lexicographic ordering. The Intel Windows comparison remains unchanged.

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Bug fix

Suggested reviewers: kraibse, takoroka, camillelavey

Merge Risk: Minimal · up to 7a083

This change fixes the NVIDIA driver-version check so that the vertex-input dynamic-state extension is no longer wrongly disabled on current drivers. No actionable merge-blocking risk was identified, and the Intel behavior is unchanged.

Security architecture risk: Minimal · up to 7a083

The change corrects a driver-version check while preserving existing feature controls. No introduced or worsened security, isolation, or failure-containment risk was identified.

Pre-merge checks: Passed 4

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title names the main change: decoding the NVIDIA driver version for the VK_EXT_vertex_input_dynamic_state check in vulkan_device. The raw summary confirms that Device::GetSuitability now decodes N…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the main change: decoding the NVIDIA driver version for the VK_EXT_vertex_input_dynamic_state check in vulkan_device. The raw summary confirms that Device::GetSuitability now decodes NVIDIA driver versions into major, minor, and patch components before comparing them with 580.119.2. The objectives describe the same fix. The title is specific and does not mention the unchanged Intel comparison, which is expected for a title.

Finishing Touches

Generate unit tests (beta)

  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 8f099419-d8f7-4f80-b397-7b1ba7057c1c
Commits

Reviewing files that changed from the base of the PR and between a9629c0 and 7a08335.

Files selected for processing: 1

  • src/video_core/vulkan_common/vulkan_device.cpp

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 7 remain after this review.

@kraibse

kraibse commented Nov 16, 2026

Copy link
Copy Markdown
Collaborator

Can test with the linux-cachyos-nvidia-open driver v620.70.06

azeselh pushed a commit to azeselh/Dalia that referenced this pull request Nov 21, 2026
…mmunity#893)

es.ts had none of the strings the nx2 frontend added that Transifex does
not cover, so Spanish users saw those windows in English. Same approach
as Eglantine-Community#827 for zh_CN.

- 404 missing messages, 10 of them in contexts es.ts didn't have yet.
- The 30 entries that were still unfinished.
- Found with lupdate (Qt 6.11.1) over src/yuzu and src/qt_common, plus
  the NVIDIA DLSS panel's Tr() strings, which lupdate doesn't see.
- Follows the terms and the formal "usted" es.ts already uses.

Existing translations are unchanged; obsolete entries are left as they
are.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
@rdenno
rdenno merged commit 164c10e into Eglantine-Community:nx2-experimental Nov 22, 2026
1 check passed
@github-project-automation github-project-automation Bot moved this from Backlog to Done in Release Tracker Nov 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants