Repository navigation
Conversation
A manual dispatch gains a linux_arch choice (both, x86_64 or aarch64) that narrows the base Linux legs and the Nix linux systems, and a build_nix tick that skips the Nix job entirely. Defaults keep pushes, dailies, PR builds and untouched manual runs building both architectures with Nix on. Cherry-picked verbatim onto nx2 and nx2-experimental so a rebase of nx2-experimental onto nx2 drops it as already applied.
`no` keeps the skip the boolean could express. `only` runs the Nix job for the systems the Linux/macOS ticks (and linux_arch) select, and skips the Linux, Windows and macOS jobs -- plus the release job, whose assets all come from those legs, so publishing there would only fail on an empty artifact set. Default stays `yes`: pushes, dailies, PR builds and untouched manual runs are unchanged.
…ds on low-RAM hosts On hosts with 18 GiB of RAM or less, the defaults reserved more than a title needs: - Dynarmic x86-64 code cache: 96 MiB per core (64 MiB at 10 GiB or less) instead of 512 MiB. EDEN_NX2_JIT_CACHE_MIB overrides it. 64 MiB filled up on Ocarina of Time and emptied the whole cache over and over, so 96 MiB is the floor for 18 GiB hosts. - NupDecompressCache: 48 MiB (32 MiB at 10 GiB or less). EDEN_NX2_NUP_CACHE_MIB overrides it. - FFmpeg decoder threads: clamp(hardware_concurrency / 3, 2, 4). Assisted-by: Antigravity (RAM profiling, implementation, and verification)
|
Retargeted to |
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Caps three caches whose defaults are sized for large hosts, only on machines with 18 GiB of RAM or less. Standalone, no dependency on the other PRs in this series (part 3 of 4).
src/core/arm/dynarmic/arm_dynarmic_64.cpp: x86-64 code cache 96 MiB per core at 18 GiB or less, 64 MiB at 10 GiB or less (was 512 MiB).EDEN_NX2_JIT_CACHE_MIB(16..512) overrides it.src/core/file_sys/nup_container.{h,cpp}:NupDecompressCache::DefaultCapForHost()gives 48 MiB (32 MiB at 10 GiB or less).EDEN_NX2_NUP_CACHE_MIBoverrides it.src/video_core/host1x/ffmpeg.cpp: decoderthread_countisclamp(hardware_concurrency / 3, 2, 4)at 18 GiB or less.I first tried 64 MiB per core on an 18 GiB host. On Ocarina of Time all 6 cores sat at ~62 of 64 MiB and the cache was flushed repeatedly (frame time minus GPU fence wait went from 3-4 ms to 22-52 ms, with 71-114 frames over 100 ms per 600). At 96 MiB that went away, so 96 MiB is the value in this PR. The 64 MiB value stays only for hosts at 10 GiB or less, which I could not test.
Assisted-by: Antigravity (RAM profiling, implementation, and verification)
Type of change
Related issues
N/A
Testing
Standalone branch:
ninja -C build -j10 yuzu eden-cli testsbuilds;./build/bin/tests "[nup]"passes (398 assertions in 21 test cases). The<= 10 GiBvalues were not run on a real 10 GiB host. Testers with 8 or 16 GiB machines are especially welcome.Games tested:
Ocarina of Time and Mario Kart World on Linux (Ryzen 5, Vega iGPU, 15.4 GiB RAM), with all 4 PRs of the series applied together. 6 Dynarmic cores at 96 MiB each ended at ~94 MiB used each in Ocarina of Time (240 s) with no cache flushes.
Checklist
Screenshots / logs
Whole series, Ocarina of Time, 240 s in game: host heap + anonymous memory (excluding JIT) 3,141 MiB before, 1,362 MiB after. Not attributable to this PR alone.
Summary by CodeRabbit