Repository navigation
Fix remote input critical/latest source watermark (#34) - #43
Merged
Merged
Conversation
2 of 3 tasks
ElSargo
commented
Sep 16, 2026
ElSargo
left a comment
Owner
Author
There was a problem hiding this comment.
Brood QA (static) — code looks good
Verdict: COMMENT LGTM for remit of #34 (critical/latest source watermark). Not a formal APPROVE (reviewer is ElSargo).
Evidence
StampedClientMessage+PRESENTATION_PROTOCOL_VERSION = 25; watermark assigned inRemoteInputLane::sendbefore critical/latest split.- Transport send/receive stamped APIs require non-zero watermark; remote
write_local_inputpublishes source-earlier pending latest before a critical, raisesapplied_barrier_watermarkon leave/focus (retires_latest_state), and drops obsolete latest samples. - Regression tests: source-earlier motion sequences before leave; leave barrier drops obsolete motion; client lane watermark ordering.
Residuals (acknowledged)
- Local
dispatch_focus_changefocus epochs still open (#41). - Mixed protocol 24/25 peers fail handshake (intentional).
CI
FAILED — GHA Nix ENOSPC (and/or disk pressure mid-build). Not treated as a logic blocker.
Stacking
Overlaps clients/brood-client/src/remote.rs with #45 and docs/frictions/ui-concurrency.md with the session-switcher stack. Prefer landing #43 before #45 on remote.rs, or rebase one onto the other.
Desktop verify: not run (needs remote session under load).
2 of 3 tasks
Stamp a source watermark before the remote lane split and carry it through both network tasks so write_local_input can publish source-earlier motion before leave/focus barriers and refuse obsolete latest-state samples. Bump presentation protocol to 25 for the stamped client-input envelope. Fixes #34.
ElSargo
force-pushed
the
fix/remote-input-source-watermark
branch
from
September 16, 2026 22:01
a46b1c7 to
b8fca0a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
source_watermarkonStampedClientMessageinRemoteInputLanebefore critical/latest split; carry through network send/receive.write_local_inputpublishes source-earlier pending latest before a critical event, then treats leave/focus as barriers that refuse older latest-state samples.PRESENTATION_PROTOCOL_VERSIONto 25 for the stamped client-input envelope on critical/latest lanes.docs/frictions/ui-concurrency.md(focus fan-out / focus transition: keyboard reset / plugin blur-focus / managed focus split across lanes without focus_epoch #41 left open).Fixes #34
Test plan
RUSTFLAGS='-C linker=cc' cargo test -p brood-protocol -p brood-transport -p brood-remote --libRUSTFLAGS='-C linker=cc' cargo test -p brood-client --lib remote::Residual risks
dispatch_focus_changefocus epochs (focus transition: keyboard reset / plugin blur-focus / managed focus split across lanes without focus_epoch #41).