draft - #459
Merged
luciaquirke merged 3 commits intoSep 13, 2026
Merged
Conversation
luciaquirke
changed the title
luciaquirke
force-pushed
the
feat/contrastive-queries-helper
branch
9 times, most recently
from
September 12, 2026 00:11
73b5423 to
f881ebf
Compare
luciaquirke
force-pushed
the
feat/contrastive-queries
branch
from
September 12, 2026 00:14
24adfb2 to
3be7a68
Compare
luciaquirke
force-pushed
the
feat/contrastive-queries-helper
branch
from
September 12, 2026 00:14
f881ebf to
35661de
Compare
Keep IndexConfig unchanged. The three query-building pipelines call build_contrast(index_cfg, control, preprocess_cfg), which runs the two builds and subtracts the control's aggregated gradient in place. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Kyh3is739zD8bg3wdiHgEn
luciaquirke
force-pushed
the
feat/contrastive-queries-helper
branch
from
September 12, 2026 00:14
35661de to
5ba9969
Compare
…rast or not Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
luciaquirke
force-pushed
the
feat/contrastive-queries-helper
branch
from
September 13, 2026 07:50
52ada60 to
1a60a77
Compare
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #458. Moves the
build-side contrast out ofIndexConfiginto a helper so the config stays unchanged.build_contrast(index_cfg, control, preprocess_cfg)inbergson/build.pybuilds the index, buildscontrolunder<run_path>/contrast, and subtracts its aggregated gradient in place. ANonecontrol is a plainbuild.trackstar,ekfacandapproxunrollingcall it with theirquery_contrast; theIndexConfig.contrastfield and its hidden-from-CLI handling are gone.bergson buildno longer takes a contrast; the pipelines and MAGIC/validate are unchanged in behaviour.Tests:
tests/test_contrast.py,test_build.py,test_builder.py,test_hessian.py,ekfac_tests, SOURCE trainer integration and checkpoint parsing all pass on an A40 (140 passed, 4 skipped).🤖 Generated with Claude Code
https://claude.ai/code/session_01Kyh3is739zD8bg3wdiHgEn