Skip to content

feat: New Text Alerting section to house Combat, Potion and Missing Talent Alerts - #2605

Draft
ericellb wants to merge 4 commits into
EllesmereGaming:mainfrom
ericellb:feat/qol-potion-and-talent-alerts
Draft

ericellb wants to merge 4 commits into
EllesmereGaming:mainfrom
ericellb:feat/qol-potion-and-talent-alerts

Conversation

@ericellb

@ericellb ericellb commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

What does this PR do?

  • New ALERTS section on the QoL page (under Auto Combat Logging)
  • This section is meant to house all different type of Text Alerts
  • Decided to add it as Combat Alert already existed, and implemented Talent Alert + Potion Alert
  • All alerts share one movable anchor ("Alerts" in Unlock Mode) and stack under it, instead of a movable frame per alert. This is so more text alerts can be added later without cluttering Unlock Mode
  • Each alert keeps its own text, size and color (cog). These are for text alerts only
  • Potion Ready Alert: green "Potion Ready" for about 3s when a potion you used is off cooldown again
  • Unspent Talents Alert: yellow text while you have unspent talent points. It stays until you spend them or middle-click it, and comes back when new points appear
  • Combat Alert moved into the section and onto the shared anchor. Its settings and saved position carry over
  • Announce Group Deaths moved into the section too. It is an alert, so this is the best place to house it. It keeps its own overlay, position and sound, so nothing changes for existing users. "Hide Item Transforms" now sits next to "Hide Loot Rolls Window" in GENERAL to close the gaps
  • Both new alerts are off by default
  • Timers: Potion Ready uses one one-shot C_Timer.NewTimer for the cooldown end, the same pattern as the Movement Alert recharge timers. No polling, unlike the existing Battle Res, Bloodlust and Group Deaths tickers. BAG_UPDATE_COOLDOWN is only registered while a potion is waiting
  • Bag scan: reads item IDs only (no per-slot tables) and classifies each item once. No alert if that was the last potion

How was it tested?

  • Looked at in game on WoW Forever: the new section, the three alerts, and the shared anchor in Unlock Mode
  • Not yet verified: retail (Midnight), and potion alerts in combat (Blizzard's API docs do not mark C_Container.GetItemCooldown as secret, so it should be readable there)

Screenshots

combat-alert.mp4
potion-alert talent-alert

Checklist

  • New settings default OFF (no behavior change without opt-in)
  • Zero cost while disabled: no events registered, no polling, no hooks doing work, no frames built
  • Cheap while enabled: event-driven (no polling, no timer-based logic, no per-frame allocations)
  • No writes onto Blizzard-owned frames (weak-table pattern used); HookScript/hooksecurefunc only, never SetScript on Blizzard frames
  • Tested in-game on live; no version gates or pre-Midnight APIs added (Forever only so far; no version gates were added)

🤖 Generated with Claude Code

…ent Talents alerts

Text alerts now share one movable anchor ("Alerts" in Unlock Mode) and stack
under it, instead of each owning a movable frame, so more alerts can be added
without cluttering Unlock Mode. Each alert keeps its own text, size and color.

- New ALERTS section under Auto Combat Logging holds Combat Alert, Potion
  Ready Alert and Unspent Talents Alert.
- Combat Alert moves onto the shared anchor and into the section; its
  settings and saved position carry over.
- Potion Ready: green "Potion Ready" when a used potion is off cooldown,
  found from its on-use spell, with one timer at the end of the cooldown.
- Unspent Talents: yellow text that stays until the points are spent or it is
  middle-clicked, using the same check as Blizzard's talent micro button.
- Both new alerts are off by default and register nothing until enabled.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@ericellb ericellb changed the title feat: ALERTS section with a shared anchor, plus Potion Ready and Unspent Talents alerts feat: New Text Alerting section to house Combat, Potion and Missing Talent Alerts Oct 9, 2026
…ns rows)

- Use C_Item.GetItemInfoInstant and defer the talent alert through ns.CombatQueue
- Read potion cooldowns through C_Container.GetItemCooldown, as the rest of the repo does
- Separate talent events and unspent-points check for Forever and retail
- Fill the QoL options rows left to right; the blank slot is on the last row

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@ericellb
ericellb marked this pull request as draft October 10, 2026 06:01
ericellb and others added 2 commits October 10, 2026 09:53
…uards)

- Move Announce Group Deaths and its cog into the ALERTS section
- Bag scan reads item IDs only; drop the secret-value fallback for item cooldowns
- Skip Potion Ready when the last potion was used
- Guard unlock registration and C_Item calls

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant