Repository navigation
Conversation
…ent Talents alerts
Text alerts now share one movable anchor ("Alerts" in Unlock Mode) and stack
under it, instead of each owning a movable frame, so more alerts can be added
without cluttering Unlock Mode. Each alert keeps its own text, size and color.
- New ALERTS section under Auto Combat Logging holds Combat Alert, Potion
Ready Alert and Unspent Talents Alert.
- Combat Alert moves onto the shared anchor and into the section; its
settings and saved position carry over.
- Potion Ready: green "Potion Ready" when a used potion is off cooldown,
found from its on-use spell, with one timer at the end of the cooldown.
- Unspent Talents: yellow text that stays until the points are spent or it is
middle-clicked, using the same check as Blizzard's talent micro button.
- Both new alerts are off by default and register nothing until enabled.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ns rows) - Use C_Item.GetItemInfoInstant and defer the talent alert through ns.CombatQueue - Read potion cooldowns through C_Container.GetItemCooldown, as the rest of the repo does - Separate talent events and unspent-points check for Forever and retail - Fill the QoL options rows left to right; the blank slot is on the last row Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ericellb
marked this pull request as draft
October 10, 2026 06:01
…uards) - Move Announce Group Deaths and its cog into the ALERTS section - Bag scan reads item IDs only; drop the secret-value fallback for item cooldowns - Skip Potion Ready when the last potion was used - Guard unlock registration and C_Item calls Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
C_Timer.NewTimerfor the cooldown end, the same pattern as the Movement Alert recharge timers. No polling, unlike the existing Battle Res, Bloodlust and Group Deaths tickers.BAG_UPDATE_COOLDOWNis only registered while a potion is waitingHow was it tested?
C_Container.GetItemCooldownas secret, so it should be readable there)Screenshots
combat-alert.mp4
Checklist
HookScript/hooksecurefunconly, neverSetScripton Blizzard frames🤖 Generated with Claude Code