Repository navigation
chore(locales): regenerate locale keys list - #2608
Closed
scavienger wants to merge 1 commit into
Closed
scavienger wants to merge 1 commit into
scavienger wants to merge 1 commit into
Conversation
Contributor
Author
|
This is the same PR as #2601. I'm going to close this PR and hope the PR approves. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Regenerates
EllesmereUILocales/_keys.txtvia.tools/extract-locale-keys.sh.Follow-up to #2476 (
feat(resourcebars): per-spec Hash Lines for Health and Power bars), which addedEllesmereUI.L("(Ex: 50000)")without updating the key list, causing thelocale-keysCI job to fail on all subsequent PRs.How was it tested?
Ran
bash .tools/extract-locale-keys.shand verified clean CI expectation.Checklist
HookScript/hooksecurefunconly, neverSetScripton Blizzard frames (N/A)