Skip to content

chore(locales): regenerate locale keys list - #2608

Closed
scavienger wants to merge 1 commit into
EllesmereGaming:mainfrom
scavienger:chore/update-locale-keys
Closed

scavienger wants to merge 1 commit into
EllesmereGaming:mainfrom
scavienger:chore/update-locale-keys

Conversation

@scavienger

Copy link
Copy Markdown
Contributor

What does this PR do?

Regenerates EllesmereUILocales/_keys.txt via .tools/extract-locale-keys.sh.

Follow-up to #2476 (feat(resourcebars): per-spec Hash Lines for Health and Power bars), which added EllesmereUI.L("(Ex: 50000)") without updating the key list, causing the locale-keys CI job to fail on all subsequent PRs.

How was it tested?

Ran bash .tools/extract-locale-keys.sh and verified clean CI expectation.

Checklist

  • New settings default OFF (no behavior change without opt-in) (N/A)
  • Zero cost while disabled: no events registered, no polling, no hooks doing work, no frames built (N/A)
  • Cheap while enabled: event-driven (no polling, no timer-based logic, no per-frame allocations) (N/A)
  • No writes onto Blizzard-owned frames (weak-table pattern used); HookScript/hooksecurefunc only, never SetScript on Blizzard frames (N/A)
  • Tested in-game on live; no version gates or pre-Midnight APIs added (N/A)

@scavienger

Copy link
Copy Markdown
Contributor Author

This is the same PR as #2601. I'm going to close this PR and hope the PR approves.

@scavienger scavienger closed this Oct 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant