Add neighbor cache support - #550
Open
vcharraut wants to merge 5 commits into
Open
Conversation
Victorbares
approved these changes
Aug 5, 2026
Victorbares
left a comment
Victorbares
left a comment
Collaborator
There was a problem hiding this comment.
I will try it out to check if max_sdc_replay_workers is still needded
Collaborator
There was a problem hiding this comment.
We should be able to remove the max_sdc_replay_workers
Collaborator
There was a problem hiding this comment.
We could put it also for the womd
| raise pufferlib.APIUsageError( | ||
| f"Benchmark config has unsupported environment keys: {', '.join(sorted(unknown_env_keys))}" | ||
| ) | ||
| default_use_neighbor_cache = environment_config.get("use_neighbor_cache", 1) |
Collaborator
There was a problem hiding this comment.
Remove the 1 as default value
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Why
Neighbor caching was always enabled and precomputed road neighbors for every grid cell. On nuPlan maps, this can consume excessive RAM and exhaust the process memory.