Repository navigation
feat: discover Mi Box devices - #9
Merged
Merged
Conversation
Mi Boxes advertise _googlecast._tcp with md=MIBOX…, so the "mitv" name filter dropped them, even though they run the same MiLink service. Accept the "mibox" prefix too, in the macOS, iOS and Android apps. Tested on a Mi Box S (MIBOX4) with the macOS app: found on the network and controlled over MiLink.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discovery skipped Mi Boxes. They advertise
_googlecast._tcplike Mi TVs, but withmd=MIBOX4(and aMIBOX4-…service name), so themitvprefix check dropped them, even though they run the same MiLink service on port 6091.miboxprefix as well asmitv, in the macOS app and in the iOS and Android native modules.md=MIBOX…, and the compatibility table lists the Mi Box S.Tested end to end on macOS
On a Mi Box S (
MIBOX4), same Wi-Fi as the Mac, with the macOS app built from this branch (./build-app.sh):main)How to test
md=MIBOX4):nc -z -w 3 <box-ip> 6091 && echo "MiLink open".cd apps/macos && ./build-app.sh && open "dist/Mi Remote.app".The mobile changes are the same one-line check and haven't been run on a device.