Conversation
Some bridges emit media URLs as `&#38;`, which reached us as a literal `&`. The `#` turned the signed CDN query string into a fragment, so Instagram returned 403, both URL and download sends failed, and posts went out as the text + "View original post" fallback instead of the media. Also record the original send error on successful fallback post_log rows so future fallbacks are diagnosable. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013A1FKXZw6wmBhXyLkn3ZKC
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
rss-bridge | 829bba7 | Sep 22 2026, 08:24 PM |
Owner
Author
|
CI The job fails at
Proposed patch, verified locally ( --- a/app/src/components/tabs/BundlesTab.tsx
+++ b/app/src/components/tabs/BundlesTab.tsx
@@ -47,7 +47,16 @@
- useEffect(() => { load(); }, [load]);
+ // Initial fetch: set state only in the async callback (react-hooks/set-state-in-effect)
+ useEffect(() => {
+ let cancelled = false;
+ callApi('list_bundles').then(res => {
+ if (cancelled) return;
+ if (!res.error) setBundles(res.data || []);
+ setLoading(false);
+ });
+ return () => { cancelled = true; };
+ }, [callApi]);
@@ -110,7 +119,7 @@
- isIn ? next.delete(feedId) : next.add(feedId);
+ if (isIn) next.delete(feedId); else next.add(feedId);Note: lint stops the job before the Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactors media URL cleaning logic into a reusable
cleanMediaUrl()function that handles both whitespace normalization and double-encoded ampersand decoding. This fixes an issue where some RSS bridges (like ImgsedBridge) double-encode ampersands in query strings, causing CDN 403 errors when the signed URLs are corrupted.Key Changes
Extract
cleanMediaUrl()helper function — Centralizes URL normalization logic that was previously duplicated across 9 call sites. The function:&#38;,&,&→&)undefinedgracefullyReplace inline
.replace(/\s+/g, '')calls — Updates all 9 occurrences inextractMedia()andextractMediaFromRSS()to use the new helper, improving maintainability and fixing the ampersand decoding issueAdd test coverage — New test case validates that double-encoded ampersands in Atom feed enclosure URLs are properly decoded to restore valid signed CDN URLs
Preserve fallback error diagnostics — Updates
queue-handler.tsto log the original error message when a fallback post succeeds, enabling better troubleshooting of why the primary send failedImplementation Details
The
cleanMediaUrl()function uses a loop to handle nested encoding (e.g.,&amp;→&→&), ensuring all variants of double-encoded ampersands are resolved regardless of how many layers of encoding were applied by upstream bridges.https://claude.ai/code/session_013A1FKXZw6wmBhXyLkn3ZKC