Skip to content

P05: Workbench UI and quick access parity - #3

Draft
Eternal-Wanderer-Vegetable wants to merge 237 commits into
mainfrom
codex/vscode-parity-p05
Draft

Eternal-Wanderer-Vegetable wants to merge 237 commits into
mainfrom
codex/vscode-parity-p05

Conversation

@Eternal-Wanderer-Vegetable

@Eternal-Wanderer-Vegetable Eternal-Wanderer-Vegetable commented Nov 5, 2026 •

Copy link
Copy Markdown
Owner

Latest slice: P05.70 Windows file identity and verification baseline

Commit 231e853 fixes reopening the same Windows file through paths with different separators/case: _openFileByPath now reuses the existing canonical-path document and existing view flow. Preview restoration exposed the duplicate-document bug after correcting Windows test node lookup. Test fixtures now compare canonical native paths, use the workbench's file URI drive-case convention and Rust LF text, and target existing editor tabs for merge/cross-document interaction.

Local validation is green: cargo fmt --check, complete bash init.sh (Rust workspace tests, Clippy -D warnings, core build, Flutter 1360/1360), flutter analyze (0 issues), Harness 100/100 and source diff checks. Initial clean-head Windows Flutter baseline was 1323 passed / 37 failed; failures and final green output are archived in docs/diagnostics/2026-11-17-p05/p05.70-windows-path-identity.md and adjacent logs.

GitNexus includes the workbench using a 1024 KiB file threshold. The shared open-file entry's pre-edit impact was HIGH (28 affected symbols, 10 direct callers, 3 process families, 2 modules). Scans remain CRITICAL. Full LocalBackend JSON exports now preserve all product 11 symbols/103 processes (26 files) and cumulative main 888 symbols/304 processes (325 files), without partial/truncated flags; this resolves CLI display caps without changing the risk assessment. Evidence commit 76113f6 archives the full exports and local Windows Release build success.

Product PR CI 43992774712 passed all four jobs (Flutter 1360 tests); Platform Availability 43992763968 passed Linux/Windows and is still running macOS. Docs-head CI 43996231773 is pending. A duplicate manually dispatched platform run 43992764009 was canceled; it is not used as evidence. P05.70 remains in progress until hosted closeout. PR #3 remains OPEN/DRAFT, and P05 overall is not complete.

Scope

P05.1 / LAY-01a implements the fixed Code-OSS 1.145.0 custom/native titlebar mode, 35 logical-pixel custom bar, platform window controls, drag/double-click behavior, and orderly close handling. Native mode keeps the existing menu entry row available.

P05.43 / feat-095 / LAY-10c adds cross-editor-group tab copy drag: with the platform copy modifier (Ctrl on Windows/Linux, Alt on macOS) a file-backed tab dropped onto a tab of another non-empty group copies as a new view of the same document at the pointer-side position; untitled documents fall back to move (upstream Singleton), the copy is never sticky or preview, an existing destination view is activated instead, and the source group stays untouched. Six focused widget tests were red-first and are green. Scope: docs/diagnostics/2026-11-14-p05/p05.43-cross-group-tab-copy-drag.md.

P05.42 / feat-094 / LAY-10b adds cross-editor-group tab drag move: a tab dragged onto a tab of another non-empty group moves the same document view, inserts before/after the destination tab by pointer side, preserves Rust-backed text/dirty/undo/selection/scroll/focus, keeps sticky partition rules, demotes a clean preview to a regular tab, activates the existing view when the destination already shows the document, removes the emptied source group, and persists the order through the session save path. Six focused widget tests were red-first and are green; same-group reorder and directional-move commands stay unchanged. Scope and evidence: docs/diagnostics/2026-11-08-p05 and docs/diagnostics/2026-11-14-p05/p05.42-cross-group-tab-drag-move.md.

P05 remains in progress. Completed so far: LAY-10 (all six sub-slices), LAY-11 (both slices), LAY-12a, LAY-13a, LAY-14 (zen mode), LAY-15 (locked scrolling), LAY-16a (explorer tree type navigation), LAY-17a/b/c (quick input steps, groups, multi-select, description columns, validation, history and item button timing), the complete LAY-18 notification surface (center, toasts, banner, Do Not Disturb, source filtering, progress notifications with cancel, and product wiring for session-journal and save failures), LAY-19a (Welcome page and empty editor-group watermark), and LAY-19b (Recent files/workspaces; local DoD and hosted gates green). Remaining: LAY-12b move-back and other directions/group-drop slices (P05.67 window/group focus and P05.68 Compact are complete; P05.69 / LAY-12b4 cross-window tab drop has local and hosted closeout; feature-specific OS cross-window DnD remains unverified), LAY-13b (editor content), LAY-16b (tree filter), remaining LAY-20 focus and drag-drop chain, and CMD-01-12 per docs/03 N.2; this PR does not claim LAY-01 or P05 completion.

Local evidence

  • bash init.sh: Rust workspace tests, Clippy -D warnings, core build, and complete Flutter suite (1,311 tests) passed. cargo fmt --check passed; flutter analyze reported 0 issues.
  • P05.61 focused Flutter suite passed 33/33: RecentHistoryStore, Welcome/File > Open Recent, and title-bar regression tests. Harness, workflow YAML, JSON, and diff checks are covered by PR CI/current checks.
  • GitNexus current all-scope analysis: 8 files, 23 symbols, 0 affected processes, LOW; no partial/truncated result. The index skips workbench_page.dart (>512 KiB), reports 984 cross-language property links it cannot resolve, and flow tracing has truncation; private workbench entry points were checked in source rather than treating absent graph callers as safe.
  • P05.61 implementation and exact evidence: docs/diagnostics/2026-11-16-p05/p05.61-recent-history.md.

Hosted checks (P05.56)

  • P05.56 command palette MRU history and item button timing (product commit f9172da): PR CI 43710612479 green on Rust (ubuntu), Rust (windows), Flutter (analyze + test) and Harness on the first attempt.
  • Platform Availability 43710607607 passed Linux x64, Windows x64 and macOS Intel x64 build/launch/package on the first attempt (the macOS lane took about 43 minutes to build). Packages Linux 14159813908 / Windows 14160870158 / macOS 14160939110; macOS ZIP SHA-256 1ebf59543fa766fd34d8e2f0ef0d4ce98a0190108fe8300f1fb016a4c1035263 matched its sidecar and tar -tf listed 81 entries. Linux/Windows DnD passed; macOS DnD records the pointer-route skip; macOS startup/native Quit passed.

Hosted checks (P05.58)

  • P05.58 notification progress and banner layer (product commit 9f184ca): PR CI 43717289132 green on all four jobs on the first attempt.
  • Platform Availability 43717284222 passed Linux x64, Windows x64 and macOS Intel x64 on the first attempt. Packages Linux 14163420702 / Windows 14163321820 / macOS 14164380775; macOS ZIP SHA-256 1423aafa0d9d31a951c890fe82a0660c0b3cf3bb7c19f3023b46bf1e6e9eb345 matched its sidecar with 81 tar entries. Linux/Windows DnD passed; macOS DnD records the pointer-route skip; macOS startup/native Quit passed.

Hosted checks (P05.61)

  • P05.61 LAY-19b Recent file/workspace history (commit 8117955): PR CI 43737761143 passed all four jobs; Platform Availability 43737756490 passed Linux x64, Windows x64 and macOS Intel x64. Package artifacts: Linux 14170923319, Windows 14170799214, macOS 14172426384. macOS ZIP SHA-256 f16a0f38c6bf111ecc54181ac46c563a0a3996129b3f41257da9409ac09112d4 matched its sidecar; unzip -tq passed with 81 entries. Linux/Windows native DnD artifacts 14170684184/14171327685 passed move/copy/external text; macOS DnD 14172052518 explicitly skipped because the hosted pointer route was unavailable. macOS startup/native Quit 14172282072 selected Quit through Accessibility and exited successfully.

Hosted checks (P05.60)

  • P05.60 LAY-19a Welcome page and empty editor-group watermark (product commit 4b1ab8f): PR CI 43726743775 passed all four jobs (Rust Ubuntu, Rust Windows, Flutter analyze + test, Harness).
  • Platform Availability 43726740538 passed Linux x64, Windows x64, and macOS Intel x64 on attempt 2. Attempt 1 failed only the ordinary macOS Release process termination smoke; the app stayed alive through the 12-second launch window but did not exit within the SIGTERM grace period. Attempt 2 passed app launch/termination and native-titlebar Quit.
  • Package artifacts: Linux 14166513148, Windows 14167316082, macOS 14169372166. macOS app ZIP SHA-256 21df2666c015af270c80b2691b53dac131abc9bbed3ba8e7b961a7ed81a93962 matched its sidecar; unzip -t passed and the ZIP contains 81 files.
  • Linux/Windows native DnD artifacts 14167171661 / 14167440497 passed local move, cross-document copy, and external text drop. macOS DnD artifact 14168769933 reports CGEventPostToPid pointer route: false; the runner delivered no Flutter pointer events, so the native DnD probe was explicitly skipped. macOS startup/native Quit diagnostics are in artifact 14169173665; the smoke log includes an Invalid engine handle message on mixin.one/desktop_multi_window, but the app remained alive and the smoke passed on attempt 2.

Hosted checks (P05.59)

  • P05.59 notification product wiring (product commit 1c780d8): PR CI 43717815102 green on all four jobs on the first attempt.
  • Platform Availability 43717810444: Linux x64 and Windows x64 passed first attempt; the macOS attempt 1 failed only the native-titlebar Quit probe (known Accessibility menu flake) and gh run rerun --failed made attempt 2 fully green for the same commit. Packages Linux 14163775562 / Windows 14162919367 / macOS 14165977230; macOS ZIP SHA-256 52d83c0684eb217dbd1c0e32cbfd659f6afa7f0e3274c2a9be3ae09440d45d2c matched its sidecar with 81 tar entries. Linux/Windows DnD 14163356720/14162674565 passed; macOS DnD 14165123118 records the input-route-unavailable skip; macOS startup/native Quit 14165643113 passed.

Hosted checks (P05.57)

  • P05.57 notification center and toast infrastructure (product commit 72edbe0): PR CI 43713492886 green on all four jobs on the first attempt.
  • Platform Availability 43713488195 passed Linux x64, Windows x64 and macOS Intel x64 on the first attempt. Packages Linux 14161079618 / Windows 14161188536 / macOS 14162062521; macOS ZIP SHA-256 de16627258b11729ddf6c0e6e66f6dfcbdbd33746f284fc8bb44ef5fdc3f51f0 matched its sidecar with 81 tar entries. Linux/Windows DnD 14161239272/14161329548 passed; macOS DnD 14162336688 records the input-route-unavailable skip; macOS startup/native Quit 14162775877 selected the native Quit item.

Hosted checks (P05.55)

  • P05.55 quick input groups/multi-select/description columns (product commit eb2d8c0): PR CI 43602681711 green on Rust (ubuntu), Rust (windows), Flutter (analyze + test) and Harness on the first attempt.
  • Platform Availability 43602675844: Linux x64 and Windows x64 passed first attempt. The macOS attempt 1 failed only the native-titlebar Quit probe (Accessibility exposed no Quit menu item and the Command-Q fallback did not close the app within 20s) while its tests, DnD, package and upload steps passed; gh run rerun --failed made attempt 2 fully green for the same commit. Packages Linux 14117216955 / Windows 14116799270 / macOS 14119581440; macOS ZIP SHA-256 df061a6d348b4cecc461dcd1bc69626c99b397c44a547155e904ec4d538127ac matched its sidecar and tar -tf listed 81 entries (exit 0). Linux/Windows DnD 14116967906/14117306446 passed; macOS DnD 14118892556 records the input-route-unavailable pointer-route skip; macOS startup/native Quit 14118678139 selected the native Quit item.

Hosted checks (P05.54)

  • P05.54 quick input steps/buttons/focus restore (product commit 4c76f44): PR CI 43597695692 green on Rust (ubuntu), Flutter (analyze + test) and Harness. The Rust (windows) job's first attempt failed on a p01_async_completion LSP exit-within-1s timing flake outside this slice; gh run rerun --failed passed and is the recorded result.
  • Platform Availability 43597691956 passed Linux x64, Windows x64, and macOS Intel x64 build/launch/package on the first attempt. Packages Linux 14114643330 / Windows 14115124198 / macOS 14115743698; macOS ZIP SHA-256 b48432585544126105659193d7ce279213e0fb9c529359fdb8afe5e596a007a6 matched its sidecar and tar -tf listed 81 entries (exit 0). Linux/Windows DnD 14115410019/14115233619 passed; macOS DnD 14116476425 records CGEventPostToPid pointer route: false with the input-route-unavailable marker (explicit skip); macOS startup/native Quit 14115968285 selected the native Quit item.

Hosted checks (P05.52)

Hosted checks (P05.52–P05.53)

  • P05.52 locked scrolling (8f8e00b): PR CI 43576370660 and 43576346720 green; Platform Availability 43576366280 passed all platforms first attempt. macOS ZIP SHA-256 eab93b3b8f924177ae73de676691ef5602bc88183c6be007ace83b9f8a34e3ae matched its sidecar. Packages 14106279486/14106965584/14106534084.
  • P05.53 explorer tree type navigation (84a4ebb + const fix f4c9e3b): PR CI 43581278183 green (an earlier run failed on a missing const flagged by CI analyze); Platform Availability 43581273926 passed all platforms first attempt. macOS ZIP SHA-256 34036b54cf81bd4e845286de2839072f3ef07c2c51f7ecf3e5547ace3a0e6a3a matched its sidecar. Packages 14108028949/14108169539/14109472798.

Hosted checks (P05.50–P05.51)

  • P05.50 modal editor infrastructure (37d9b0a): PR CI 43567482106 green; Platform Availability 43567477181 passed all platforms first attempt. macOS ZIP SHA-256 fd1c96657bd19f4ea2090d3c9bbe0b32c5b14833f04af706a6939af16cbcbdef matched its sidecar. Packages 14102293709/14102668093/14103767897.
  • P05.51 zen mode (93004be): PR CI 43571911894 green; Platform Availability 43571908099 passed all platforms first attempt. macOS ZIP SHA-256 d1151eb1a18d9eb8b1bde02ba3c3e07aeaf5db45c1a4eba766a8af6530a6490e matched its sidecar. Packages 14104737408/14105176539/14106110290.

Hosted checks (P05.46–P05.49)

  • P05.46 MRU group activation on close (fb11af1): PR CI 43546577773 and 43546193275 green; Platform Availability 43546188540 passed all platforms first attempt. macOS ZIP SHA-256 d92ab967026b03d91e1fccd38ad70cff1f0feac0b1219c0bad33c2bae9677e21 matched its sidecar. Packages 14093728801/14094213629/14095217944.
  • P05.47 Open Editors sidebar section (a546401): PR CI 43548589301 green; Platform Availability 43548021157 passed all platforms first attempt. macOS ZIP SHA-256 0c25389b8e87f1ca0fc21a6cc296fdcc7b87b2d91c24a44eb174f61325a4ee8a matched its sidecar. Packages 14094652383/14095287068/14096606182.
  • P05.48 breadcrumb pickers (d6ef4e2): PR CI 43549908069 green; Platform Availability 43549903926 passed all platforms first attempt. macOS ZIP SHA-256 50ad8b313d521b28b0b6727f025c4ebe59a7861071b580a3c2d7c8daff475ef3 matched its sidecar. Packages 14096110427/14096016357/14096153694.
  • P05.49 auxiliary window infrastructure (ee21419/f29c3bc): PR CI 43550219144 and 43563107338 green; Platform Availability 43553752557 (dependency) and 43563101735 (step 2) passed all platforms; the dependency run's first macOS attempt hit a transient CocoaPods CDN clone failure and was rerun per the infrastructure-flake precedent. macOS ZIP SHA-256 4a0b6faa6e4ce4244d29266e74761714d62668817641a1fb66c15bfe28dcbd35 matched its sidecar. Packages 14101012506/14101446957/14102121611.
  • All four slices: Linux/Windows DnD passed; macOS DnD records the pointer-route skip (input-route limitation, unchanged).

Hosted checks (P05.44 + P05.45)

  • P05.44 group-area drop append (commit 0e0c245): PR CI 43537435255 passed all four jobs; Platform Availability 43537430640 passed Linux x64 (3m58s), Windows x64 (9m16s), and macOS Intel x64 (40m32s) on the first attempt. Packages Linux/Windows/macOS 14091010614/14090717792/14091498775; Linux/Windows DnD passed; macOS DnD 14091264167 records the pointer-route skip; macOS ZIP SHA-256 fd66c46ec60d68c562b787049e34f7fa5b9840a3c3394d00c134277237aca265 matched its sidecar and unzip -tq passed.
  • P05.45 split-drop group creation (commit b5cb7ab): PR CI 43540285378 passed all four jobs; Platform Availability 43540279332 passed Linux x64 (4m13s), Windows x64 (6m44s), and macOS Intel x64 (40m47s) on the first attempt. Packages Linux/Windows/macOS 14092160846/14091917079/14093007643; Linux/Windows DnD passed; macOS DnD 14092653452 records the pointer-route skip; macOS ZIP SHA-256 0ada53614f25e2e7b357bef0d830ee2cd0abf6ac61448a93bfd0daac7ede2c32 matched its sidecar and unzip -tq passed.

Hosted checks (P05.43, commit e7a4c71)

  • PR CI 43526231853 passed all four jobs (the registration commit's CI 43523663261 is also green).
  • Platform Availability 43526222287 passed Linux x64 (3m52s), Windows x64 (10m1s), and macOS Intel x64. macOS attempt 1 hit one timing-sensitive regex-replace test unrelated to this slice; attempt 2 passed all macOS lanes in 31m13s and is the recorded result.
  • Package artifacts: Linux 14085701199, Windows 14085113311, macOS 14088930789. Linux/Windows DnD 14085666158/14085322762 passed. macOS DnD 14087679848 records the pointer-route skip. Startup diagnostics 14089130338. macOS ZIP SHA-256 e98450d7664a64aa03a7d2c767266156ae536934086b28932bcf73e2ef98684c matched its sidecar and unzip -tq passed.

Hosted checks (P05.42, commit 3b99d9d)

  • PR CI 43462799690 passed all four jobs after pinning ci.yml to flutter 3.47.8: the previously unpinned action pulled the 3.50 line where package:flutter/material.dart emits 136 deprecated_member_use infos (first attempt 43461120019 failed at Analyze; the material_ui import migration is registered follow-up work).
  • Platform Availability 43464279815 passed Linux x64 (3m50s), Windows x64 (10m38s), and macOS Intel x64. macOS attempt 1 hit two timing-sensitive tests unrelated to this slice (workspace watcher subscription count, git panel label); attempt 2 passed all macOS lanes in 38m40s and is the recorded result, following the established timing-flake precedent.
  • Package artifacts: Linux 14058675797, Windows 14059195873, macOS 14063417573. Linux/Windows DnD 14058480492/14058507242 passed. macOS DnD 14062792311 records CGEventPostToPid pointer route: false with all tests skipped (input-route limitation; does not verify native DnD). Startup diagnostics 14063123037. macOS ZIP SHA-256 ae9844907a8693323c5a95c5859dd1e28b23f2776f0d54297dd2ee5633d99cc2 matched its sidecar and unzip -tq passed.

Hosted checks

  • PR CI on product commit d6e297d passed all four jobs. A docs-only evidence commit 9573290 is now pushed; its PR CI rerun is pending.
  • Platform Availability run 42032120138 passed Linux x64 (5m46s), Windows x64 (11m48s), and macOS Intel x64 (28m58s) build/launch/package lanes, including native-titlebar smoke.
  • Package artifacts: Linux 13415944530, Windows 13417376645, macOS Intel x64 13417219623. macOS ZIP SHA-256: bb12d417b2bfdd2239cbba57c02467beb1bd137bedc84b01525b88cb5d50ad5e; sidecar matched and ZIP integrity passed. Startup diagnostics: 13417639020.
  • Linux and Windows DnD smokes passed. macOS DnD diagnostics 13418970398 show CGEventPostToPid pointer route: false, no Flutter pointer events, and All tests skipped; the workflow records this input-route limitation as skipped, not as DnD passing. Apple Silicon/native-device validation remains P15.

P05.69 / feat-121 / LAY-12b4 — local implementation

  • Commit: f0c67bd8c3bb1b65964e7dcce784664e38522440. Main-window tab drops onto a uniquely hit registered auxiliary window use a prepare/commit/abort/status swap; the target's prior single document returns to the main window. Bounds are event driven and capped at 32 windows. P05.67 focus snapshots remain window/group-only; document identity/content is not added to the focus channel.
  • Local verification: focused tests 32/32; cargo fmt --check; flutter analyze 0 issues; bash init.sh passed Rust 125 tests, Clippy, core build and Flutter 1,360/1,360; Harness 100/100. Scope and GitNexus evidence: docs/diagnostics/2026-11-17-p05/p05.69-auxiliary-window-cross-window-drop.md.
  • Hosted PR CI 43941953054 passed all four jobs. Platform Availability 43941942416 passed Linux x64, Windows x64 and macOS Intel x64 build/test/launch/package jobs.
  • App artifacts: Linux 14264550521, Windows 14264616080, macOS 14265886712; macOS startup/native Quit diagnostics 14266101279, with native Quit successful.
  • Linux/Windows generic native move/cross-document copy/external-text DnD diagnostics: 14265025133 / 14263916308 passed. macOS DnD artifact 14266081126 records CGEventPostToPid pointer route: false and no Flutter pointer events, so the native probe was skipped.
  • These DnD fixtures do not launch Alula auxiliary or exercise its document swap; P05.69 feature-specific native cross-window DnD remains unverified.

Known parity boundary

The current window_manager GTK hidden mode removes Linux decorations, so Linux custom mode draws its own window buttons. Windows and macOS keep native caption controls. This differs from Code-OSS's Windows custom-button style and remains recorded for later implementation. Menu hierarchy, mnemonics, and the macOS system menu are also separate open P05 work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant