fix(tools): page through MCP tools/list nextCursor - #302
Open
icn5381 wants to merge 1 commit into
Open
Conversation
connect_mcp_servers called list_tools() once and registered only the first page, so any MCP server that paginates tool discovery silently exposed a partial tool surface. Follow nextCursor page to page until the server stops returning one, guarding against a repeated cursor trapping discovery in a loop. Co-authored-by: Claude (claude-opus-5) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
connect_mcp_servers called list_tools() once and registered only the tools on the first page. A server that paginates tool discovery (returns a nextCursor) silently exposed a partial tool surface: every tool past the first page was omitted with no error.
Follow nextCursor page to page until the server stops returning one, then register the full set. Track seen cursors so a misbehaving server that re-issues the same cursor cannot trap discovery in a loop.
The paging loop lives in a new _collect_tools helper so it is unit-testable without standing up a transport/registry.
Type
Verification
uv run pytest tests/test_mcp_tools_pagination.py -v-> 3 passeduv run ruff format(2 files unchanged),uv run ruff check(all passed)Risk
Related Issues
Fixes #301