Repository navigation
feat(gc573): overhaul JSON-RPC IPC with jsmn parser and expand unit tests - #56
Merged
Merged
Conversation
…er handlers - Enforce object key validation in json_token_find_key to prevent matching string values - Prioritize root object keys before searching nested parameter objects - Wire streamer handling in apply_ipc_command for TOAST, EDID, HOTPLUG, and HDR_EV - Add toast_render OSD overlay for centered toast notifications - Implement gc573_user_it6664_pulse_hpd for HDMI source re-sync - Avoid resetting active HDR exposure on hdr.passthrough calls - Add unit test coverage for duplicate key-value string collisions
Owner
|
Thank you so much for this PR and the clean jsmn parser refactor! We tested this locally on real GC573 hardware and verified everything. While testing, we found and fixed a small edge case in the tokenizer and completed the streamer wiring:
Everything compiled without any warnings and ran smoothly in our local hardware tests. We pushed these fixes directly to your branch so you have them right away. Thank you again for the great work! |
PolygonPrincess
marked this pull request as ready for review
November 10, 2026 00:01
Contributor
Author
|
@Everlite Marked this as ready for review, thanks for testing this and providing these fixes and completing the streamer wiring! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the hand-rolled string-scanning JSON parser in
gc573_user_ipc.cwith the fast, MIT-licensedjsmnparser:JSON_GET_RAW./dev/video[0-9]+) and prevents malformed token buffer overruns.tests/test_ipc_json.ccovering normal RPC operations, numeric IDs, malformed JSON, truncated buffers, and NULL-pointer negative edge cases.This needs testing on GC573 as this is a GC573 improvement and I do not have the hardware to test for this myself.