Repository navigation
fix(core): preserve atomic input and teardown state - #852
Merged
Merged
Conversation
Bundle ReportChanges will increase total bundle size by 543 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: exo-full-iife-min-Exo-iifeAssets Changed:
view changes for bundle: exo-iife-min-Exo-iifeAssets Changed:
Files in
view changes for bundle: exo-full-iife-Exo-iifeAssets Changed:
view changes for bundle: exo-iife-Exo-iifeAssets Changed:
Files in
view changes for bundle: exo-esm-esmAssets Changed:
Files in
view changes for bundle: exo-esm-modules-esmAssets Changed:
Files in
Files in
|
Exoridus
force-pushed
the
sweep/v020-19-collection-batching
branch
from
October 18, 2026 07:09
ed2adcf to
f2cf398
Compare
Exoridus
force-pushed
the
sweep/v020-integration-lifecycle
branch
from
October 18, 2026 08:01
34662c8 to
51410cd
Compare
❌ 1 Tests Failed:
View the top 1 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pausing from a fixed-step callback could clear discrete input counts before later readers in the same step observed them. A lifecycle abort listener could also reenter application destruction before the shared destroy promise was stored, starting duplicate teardown. Preserve the delivered tick snapshot until the step expires and publish the shared teardown promise before callbacks can reenter.
Focused regressions reproduce both failures before the fixes. The final clean commit passes 230 tests across input delivery, shutdown outcomes, teardown ownership, frame boundaries, cleanup isolation and preparation cancellation. The tests retain next-step expiry, shared promise identity, once-only cleanup and dependency-lifetime assertions.
Stack base:
sweep/v020-19-collection-batchingated2adcfda8eaa0aab599fcc6ac5974d9f3cbd6c9. Head:34662c81a66800aa0f7919d6d774cc87f0304116. This reconciles input and teardown above the preceding scoped PRs.Validation:
pnpm exec vitest run --project=exojs test/input/input-tick-delivery.test.ts test/core/application-destroy-outcome.test.ts test/core/application-teardown.test.ts test/core/scene-frame-boundary.test.ts test/core/lifecycle-cleanup-isolation.test.ts test/core/application-lifecycle-guards.test.ts test/core/scene-prepare-cancellation.test.ts. Broader candidate qualification and exact-SHA CI evidence are recorded below.This stacked base requires explicit workflow dispatch because the repository pull-request trigger covers
mainandnextonly. Exact-head CI is recorded below.Published validation evidence
34662c81a66800aa0f7919d6d774cc87f0304116: CI run 38845665397, completed / success.Combined stack:
d195528c3e265e7d23ba2198813a6324a28c6476, treec64f60bfd5d5e5a4210281ff6b3bfe120482fac1. Integration qualification: CANDIDATE_QUALIFIED. These combined results belong to that SHA, not to each earlier stack head.Combined mandatory evidence: 18/18 final CI jobs; normal local pre-push gates and seven selected lanes; Firefox WebGL2; 162 parity checks; 108 full-example smoke passes with one intentionally WebGPU-only skip; all six generated starter builds; 13 hashed candidate tarballs and strict public-package consumers. Existing package versions remain 0.19.1; artifacts are unpublished candidate builds.
Local Firefox WebGPU executed and failed: Core 3 failures, media 4 failures, isolated row timeout. Mesh and video-copy failures also reproduce on the verified base; two full-suite Core timeouts do not reproduce in fresh named runs. CI Firefox WebGPU is separately UNSUPPORTED_HOST. These informational outcomes remain failures/unsupported, not passes. Tiled 1.12.2 authentic exports remain unverified; strict NodeNext declarations remain unsupported.
Firefox WebGPU follows the existing informational policy. An unsupported host is not an executed rendering pass. This branch is unmerged; no release or package publication is implied.