Repository navigation
feat(examples): playground quality and experience sweep - #860
Merged
Merged
Conversation
Bundle ReportChanges will increase total bundle size by 21.09MB (59.07%) ⬆️
Affected Assets, Files, and Routes:view changes for bundle: site-server-esmAssets Changed:
App Routes Affected:
|
Owner
Author
Independent review of
|
Exoridus
force-pushed
the
polish/playground-quality-sweep
branch
from
October 21, 2026 12:53
75e5d46 to
c625455
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A quality and experience pass over the playground. The implementation audit covered all 109 original catalog entries using captures requested at settle, 2 s, 5 s and 10 s and, where an example plays audio, level measurements. Only entries with a demonstrated problem changed. Sixteen commits on top of
next(the audio core fix of #859 is already innextand is no longer part of this branch), grouped by theme below.How the evidence was taken
Visual: the catalog smoke route in headless Chromium 153, with wall-clock capture targets after the canvas mounted, using the
--shot-timesoption this PR adds. These are best-effort requested times, not deterministic simulation frames. The settle checks run before the timed series, so an overdue capture can be taken later than its filename suggests; every series therefore writes a<example>.captures.jsonsidecar with the requested and observed time, the lateness and any capture that failed, and the file names are not evidence of the exact time. Contact sheets were compared before and after; they are available on request.Audio:
AudioContext.destinationwhile Playwright drives the real playground route. No package API is involved.Mix limits, fixed before any tuning:
The implementation report records compliance for its tested scenarios across all 24 examples with audio. This is not a claim that every possible parameter combination has been exhaustively tested. The detailed scenario matrix, measurement harness and raw measurements have not been attached to this PR, so the aggregate claim is not yet independently reproduced here.
Audio
fix(examples): level-match the effect chains and leave headroom for one-shotsThe chain trim is reset on bypass and on destroy.
fix(examples): keep the dry voice out of the vocoder mixfeat(examples): place the spatial audio source with a mono pulse(listener-and-source)feat(examples): choose convolution rooms from a panelandfix(examples): strike convolution pads on quick clickspointer.buttons, which has already been released when the queued press is delivered at the next frame.destroy(), so the effect stayed on the sound bus.trackPressButtonsis unit-tested and the behaviour was checked in the browser with a synthesized quick right click and left click.destroy()removes the effect, the input handlers and the panels.fix(examples): start the spaceship engine after the audio unlock(gamepad-spaceship)AudioGeneratorwas started ininit()while audio was still locked, so it was dropped and never sounded. When audio happened to be unlocked, it was a raw sawtooth at up to 0.38. Visually: grey circles and a tiny ship.onUnlockon its own bus, behind a low-pass filter. The cutoff and level follow the smoothed thrust (−8.6 dBFS peak).feat(examples): add an audio signal graph showcase(new:audio-fx/signal-graph, in the "audio" catalog, linked from the Audio effects guide)First impression
feat(examples): replace the placeholder ship and announce the hello world interactionship-a.pngwas a 64×64 pale chevron about 30 px wide. It is the placeholder in 23 catalog entries, among them hello-world, sprite-basics, blendmodes, blur-filter, water-mirror, render-to-texture, easing-curves, tween-* and boss-intro, and read as a tiny white mark on dark backgrounds.hello-world: the ship is shown at 1.5×, an on-canvas hint tells the player the ship is clickable and reflects the paused state, and the background is dark blue. The guide region is unchanged.Particles
fix(examples): size particle effects in texture scaleEvery particle texture is 512×512 px, and
ScaleOverLifetimesets the absolute scale.emitter-basicspeaked at scale 0.55 and moved at 70–180 px/s, so it showed a ~100 px blob instead of a fountain.cursor-attractor-particlesandaudio-reactive-particlesdrew 90–110 px particles.feat(examples): layer the fireworks and campfire effectsComparison lab
feat(examples): compare texture sampling modes side by sidearia-pressedfollow the shortcut (checked in the browser).Controls and QA
feat(examples): show focus, hover and pressed states on example controlsprefers-reduced-motion.role="group"and a label, toggles carryaria-pressed, and sliders and cycle arrows carryaria-label. Buttons aretype="button".test(site): capture examples at fixed times in the smoke run--shot-times 2,5,10requests additional wall-clock captures after the canvas mounted. They are review evidence, not a deterministic timing guarantee. Each series writes a sidecar with requested and observed times, lateness and failures; the smoke verdict stays separate.Validation
pnpm gates typecheck/sync/site, ESLint and Prettier on the changed files, andexamples:sync:checkall pass in the implementation report.next; see the checks of this PR.75e5d464eand its smoke artifact (107 passed, 3 host skips) belong to the previous head and do not qualify this one.Not verified
listener-and-source, the spaceship engine and the vocoder.