Repository navigation
feat(clips): enable Recording Clip creation for qualification - #482
Merged
Merged
Conversation
Exoridus
marked this pull request as ready for review
October 25, 2026 01:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enables Recording Clip creation in the development build so it can be qualified together with the remaining v0.11 hardware acceptance.
Changes
product::kRecordingClipsAvailableis nowtrue. The retained clip engine, coordinator worker, adapter, transport action, overflow entry and clip panel become active. No runtime switch was added.clip.recording-live(revision 4, release-gpu and preflight) is the active required clip scenario.clip.creation-unavailable(revision 1) is retained outside the registry for a source-level deactivation. Plan and report tests now pin the positive contract and confirm that a passing negative result cannot stand in for it.InvalidConfigwithout committed recording media and a constructed clip worker. The transport QML test checks the Save clip action, the overflow entry and the panel loader against the capability. Two pure disabled-boundary tests skip while the capability is on. Their positive counterparts already exist.Release impact
v0.11 cannot be released with this change until
clip.recording-livepasses on a candidate and the open qualification items are closed: the inclusive 33,554,432-byte per-active-job memory contract, long split-spanning media, and concurrent recording/export/storage pressure. The memory contract is still unproven.Verification
cargo test --manifest-path tools/exo-verify/Cargo.toml: 327 passed.cargo exo-dev test --exclude-label live: all tests outside the five updated binaries passed. Those five were then re-run in isolation and pass (admission, live_verify policy and protocol, recording_clip adapter, record_source_picker QML).Not verified
clip.recording-livehas not run against this build.