fix: Notification appears when user is focused on the report#96891
fix: Notification appears when user is focused on the report#96891nkdengineer wants to merge 9 commits into
Conversation
|
@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5968fd14f9
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| const centralPaneReportParams = getTopmostReportParams(state); | ||
| if (centralPaneReportParams?.reportID) { | ||
| return centralPaneReportParams; |
There was a problem hiding this comment.
Respect the active tab before returning an inbox report
When the user is focused on a Search fullscreen money-request report while an inbox report remains mounted in REPORTS_SPLIT_NAVIGATOR, getTopmostReportParams can still find that preserved ReportsSplit route inside TAB_NAVIGATOR without considering the tab index. Returning it here before checking the active Search tab makes Navigation.getFocusedReportId() report the inactive inbox report, so shouldShowReportActionNotification() still shows notifications for the Search report the user is currently viewing. Please derive the focused tab route first, or check Search when it is the active tab before falling back to the inbox report.
Useful? React with 👍 / 👎.
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
Explanation of Change
fix: Notification appears when user is focused on the report
Fixed Issues
$ #95711
PROPOSAL: #95711 (comment)
Tests
Precondition: User A has a one-single expense report
Steps:
Offline tests
QA Steps
Same as test
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2026-07-23.at.22.27.31.mov
Android: mWeb Chrome
Screen.Recording.2026-07-23.at.22.25.27.mov
iOS: Native
Screen.Recording.2026-07-23.at.22.18.47.mov
iOS: mWeb Safari
Screen.Recording.2026-07-23.at.22.22.34.mov
MacOS: Chrome / Safari
Screen.Recording.2026-07-23.at.22.14.36.mov