Skip to content

Fix: Screen Reader: Many Pages: There is no dialog role and title announced #96892

Open
Krishna2323 wants to merge 5 commits into
Expensify:mainfrom
Krishna2323:krishna2323/issue/76944
Open

Fix: Screen Reader: Many Pages: There is no dialog role and title announced #96892
Krishna2323 wants to merge 5 commits into
Expensify:mainfrom
Krishna2323:krishna2323/issue/76944

Conversation

@Krishna2323

@Krishna2323 Krishna2323 commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Explanation of Change

Fixed Issues

$ #76944
PROPOSAL:

Tests

Setup

  • Windows + Chrome
  • Screen reader: JAWS or NVDA (test both)
  • Logged-in account
  • Wide layout (desktop width) so the RHP is a dialog

Primary flow (issue repro)

  1. Open Settings → About (/settings/about).
  2. Tab to App download links.
  3. Press Space or Enter to open it.
  4. Listen to what is announced.

Pass

  • Something like “App download links, dialog” (wording may vary slightly by SR).
  • Focus ends on Back (or the first control in the panel).
  • JAWS does not cut off the browser tab unread like “left paren…” mid-word before the dialog announce.

Fail

  • Only “Back” / button, with no dialog + title.
  • Focus stays on App download links on the About page.

Quick extras

  1. Open the same panel with Enter as well as Space.
  2. Close with Back / Escape, reopen — title should announce again.
  3. Optional: open another titled RHP the same way (any Settings sub-page) and confirm the same pattern.
  • Verify that no errors appear in the JS console

Offline tests

  • Same as tests

QA Steps

  • Same as tests

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
android_hybrid.mp4
Android: mWeb Chrome
iOS: Native
ios_hybrid.mp4
iOS: mWeb Safari
MacOS: Chrome / Safari
web_chrome_jaws.mp4
web_chrome_nvda.mp4
web_chrome_voiceover.mp4

Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
@melvin-bot

melvin-bot Bot commented Jul 23, 2026

Copy link
Copy Markdown

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

  1. Look at the code and make sure there are no malicious changes.
  2. Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

@codecov

codecov Bot commented Jul 23, 2026

Copy link
Copy Markdown

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
src/components/DialogLabelContext.tsx 95.83% <100.00%> (+1.71%) ⬆️
src/components/Header.tsx 100.00% <100.00%> (ø)
src/hooks/useDialogContainerFocus/index.ts 92.00% <100.00%> (+2.52%) ⬆️
src/hooks/useDialogLabelRegistration.ts 84.61% <100.00%> (+1.28%) ⬆️
src/libs/claimInitialFocus.ts 83.33% <62.50%> (-16.67%) ⬇️
...on/AppNavigator/Navigators/RightModalNavigator.tsx 0.00% <0.00%> (ø)
src/hooks/useAccessibilityAnnouncement/index.ts 0.00% <0.00%> (ø)
... and 168 files with indirect coverage changes

@Krishna2323

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@Krishna2323

Copy link
Copy Markdown
Contributor Author

@MelvinBot review

@mkhutornyi

Copy link
Copy Markdown
Contributor

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e57a11c64a

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread src/libs/Navigation/AppNavigator/Navigators/RightModalNavigator.tsx Outdated
Comment thread src/hooks/useDialogContainerFocus/index.ts
@MelvinBot

Copy link
Copy Markdown
Contributor

🤖 Reviewed the changes — this is a well-crafted, focused accessibility fix. The move from imperative setAttribute('aria-label') to declarative React props (so JAWS's virtual buffer sees role + name in the same commit) is the right call, the code comments explain the why clearly, and the unit tests were updated to match the new declarative contract. Nice work.

A few things worth confirming before merge — none are blockers, but two are genuine cross-cutting behavior changes that reach beyond the JAWS-on-web path this PR targets.

1. Focus is now stolen into every wide RHP regardless of input modality

useDialogContainerFocus/index.ts drops the getHadTabNavigation() gate for role="dialog" and calls the new claimDialogFocus, which no longer requires document.activeElement === body. This is correct per the APG modal pattern, but it means mouse users now also have focus moved into the panel on open (previously that only happened after keyboard nav). The ring is still suppressed (focusVisible: false), so it should be invisible — but please sanity-check any wide RHP that auto-focuses its own control on mount (e.g. a search field or amount input) when opened with a mouse, to make sure this post-transition focus steal doesn't fight the page's own autofocus.

2. Web dedup logic change affects 4 other callers

useAccessibilityAnnouncement/index.ts replaces the old prevShouldAnnounceRef gate with a previousMessageRef/announcementKey dedup that mirrors the native hook. This is a good consistency win, but it changes web behavior for the existing callers, not just Header: DatePicker, MagicCodeInput, ValidateCodeCountdown, and useDebouncedAccessibilityAnnouncement. Worth a quick verification that repeated/identical announcements in those flows (e.g. re-entering the same magic code, reopening the date picker) still announce as expected.

3. accessibilityRole={CONST.ROLE.NONE} in HeaderWithBackButton applies on native too

HeaderWithBackButton is a single index.tsx with no platform split, so the four new accessibilityRole={CONST.ROLE.NONE} props also render on iOS/Android. The intent (suppress JAWS "group" chrome on web) is web-specific — please confirm this doesn't change how VoiceOver/TalkBack group or traverse the header on mobile, since native wasn't the target here.

Minor / nits
  • Header announcement is web-only by design — only shouldAnnounceOnWeb: true is passed (no shouldAnnounceOnNative), so index.native.ts stays silent and politeness is ignored there. 👍 No native regression from the announcement itself.
  • Orphaned live-region on root changegetWrapper keys wrappers by politeness and re-parents the active one when the announcement root changes, but the other politeness's wrapper can be left orphaned in the old (removed) root until its next call. It self-heals and lives in a detached subtree, so harmless — just noting it.
  • The removed pushLabel does not crash when containerRef.current is a non-DOM object ... (HybridApp native View) test is correctly dropped since updateContainerLabel/DOM setAttribute no longer exists — good cleanup, not a coverage gap.

This is an automated review. Reply with @MelvinBot <feedback> to refine it.

Signed-off-by: krishna2323 <belivethatkg@gmail.com>
@Krishna2323
Krishna2323 marked this pull request as ready for review July 23, 2026 16:45
@Krishna2323
Krishna2323 requested review from a team as code owners July 23, 2026 16:45
@melvin-bot
melvin-bot Bot requested a review from mkhutornyi July 23, 2026 16:45
@melvin-bot

melvin-bot Bot commented Jul 23, 2026

Copy link
Copy Markdown

@mkhutornyi Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot requested review from JmillsExpensify and removed request for a team July 23, 2026 16:45
Comment thread src/libs/Navigation/AppNavigator/Navigators/RightModalNavigator.tsx

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 308517ba3a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/components/Header.tsx Outdated
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
@Krishna2323

Copy link
Copy Markdown
Contributor Author

@mkhutornyi ready for review

@github-actions

Copy link
Copy Markdown
Contributor

🚧 amyevans has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

Copy link
Copy Markdown
Contributor

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #96892.

Android 🤖 iOS 🍎
❌ FAILED ❌ https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-e22fea4-d815402-dcdcbac487882ac68f961a350841b7c5ec848f4e/index.html
The QR code can't be generated, because the Android build failed iOS
Web 🕸️
https://96892.pr-testing.expensify.com
Web

👀 View the workflow run that generated this build 👀

@mkhutornyi

Copy link
Copy Markdown
Contributor

JAWS or NVDA both work well

@mkhutornyi

mkhutornyi commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Android: mWeb Chrome
iOS: HybridApp
iOS: mWeb Safari
MacOS: Chrome / Safari
demo.mp4

@MelvinBot

Copy link
Copy Markdown
Contributor

🤖 Re-reviewed the current diff (the earlier HeaderWithBackButton ROLE.NONE changes are gone — this is now a clean declarative refactor). This is in good shape: moving dialog naming out of imperative setAttribute('aria-label') and into React state (dialogAriaLabel) applied as declarative role/aria-modal/aria-label props on the RHP container is the right fix, so JAWS's virtual buffer sees the role + name committed together. Tests were updated to match the new declarative contract, and mkhutornyi already confirmed JAWS + NVDA both announce correctly. Nice work.

One concrete thing to confirm, plus two cross-cutting behavior changes that reach beyond the JAWS-on-web path this targets.

1. isTransitionReady now gates on dialogAriaLabel — titleless wide RHPs no longer claim focus

useDialogLabelRegistration.ts:447 adds && !!dialogAriaLabel to isTransitionReady. dialogAriaLabel is only populated when a non-empty title is registered, and the focus-claim (useDialogContainerFocus) only runs from the inner Header with isScreenHeader ? title : ''. So a wide RHP whose screen header has an empty title will no longer steal focus into the panel after the transition — previously it would once didScreenTransitionEnd. Progress-bar and avatar-display headers don't render the focusing Header at all, so they're unaffected; the gap is specifically a titleless isScreenHeader header. Worth confirming no such route relied on the post-transition focus move (a nameless dialog arguably shouldn't announce anyway — just make sure it's intentional).

2. Focus is now moved into every wide RHP regardless of input modality

useDialogContainerFocus/index.ts drops the getHadTabNavigation() gate for role="dialog" and calls the new claimDialogFocus (which no longer requires document.activeElement === body). Correct per the APG modal pattern, but it means mouse users now also get focus moved into the panel on open (previously keyboard-only). The ring is suppressed (focusVisible: false), so it should be invisible — please sanity-check any wide RHP that autofocuses its own control on mount (search field, amount input) when opened with a mouse, so the post-transition steal doesn't fight the page's own autofocus.

3. Announcement dedup rewrite touches all web callers of the hook

useAccessibilityAnnouncement/index.ts swaps the prevShouldAnnounceRef gate for a previousMessageRef/announcementKey dedup mirroring native. The behavior only diverges from the old code when a non-message dep changes (or the hook remounts) while the message stays identical and shouldAnnounceMessage stays true — old re-announced, new dedups. The callers that need to re-fire an identical message (useTaskCheckboxAccessibility, FormHelpMessage, FormProvider) already pass announcementKey, so the blast radius looks small — but there are ~15 web callers of this hook now, so a quick pass over the error-repeat flows (e.g. MagicCodeInput, ValidateCodeCountdown) to confirm they still announce as expected would be worthwhile.

Minor / nits
  • getWrapper orphangetWrapper now keys wrappers by politeness and re-parents the active one when the announcement root changes, but the other politeness's wrapper can be left orphaned in the old (removed) root until its next call. It self-heals and lives in a detached subtree, so harmless — just noting.
  • Header announcement is web-only by design — only shouldAnnounceOnWeb: true is passed (no shouldAnnounceOnNative), so index.native.ts stays silent and politeness is ignored there. 👍 No native regression from the announcement.
  • The dropped pushLabel does not crash … (HybridApp native View) test is correctly removed since the DOM setAttribute path it guarded no longer exists — good cleanup, not a coverage gap.

This is an automated review. Reply with @MelvinBot <feedback> to refine it.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. More of your lovely PRs please.

Reviewed commit: e22fea4e4b

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@MelvinBot

Copy link
Copy Markdown
Contributor

🤖 Regression sweep — overall low risk. I traced the three behavior changes with the widest blast radius (the focus-steal, the announcement dedup rewrite, and the focus-claim interactions) against the rest of the codebase. Most of what looks risky is actually guarded. Two things are worth a manual confirm; everything else I was able to rule out with code evidence.

Worth confirming (real behavior changes)

1. Transient focus-flash on a mouse-opened wide RHP that autofocuses its own input. The steal now fires for mouse users too (the getHadTabNavigation() gate was dropped for role="dialog"). Two guards prevent focus from being stuck on the wrong element: the containment check in useDialogContainerFocus/index.ts:27-30 bails when focus is already inside the panel, and page autofocus claims AUTO priority which vetoes claimDialogFocus's INITIAL priority (ScreenFocusArbiter.ts:6-31). But both systems fire after didScreenTransitionEnd, so on a wide RHP that autofocuses an input without setting shouldSkipFocusAfterTransition and not under a screen reader, there's a window where claimDialogFocus can focus the back button first before AUTO moves focus back to the input — a brief visible flash, not a stuck-focus bug. Worth a quick mouse-open check on an autofocusing wide RHP (e.g. an amount/search step). Pages that intentionally autofocus and already pass shouldSkipFocusAfterTransition (e.g. IOU confirmation, New Task) short-circuit the steal and are fine.

2. Titleless wide RHPs no longer claim focus after the transition. useDialogLabelRegistration.ts:447 now requires !!dialogAriaLabel for isTransitionReady, and the only focusing path (useDialogContainerFocus) runs from the inner Header with isScreenHeader ? title : ''. A wide RHP whose screen header has an empty title won't move focus into the panel anymore (previously it would once the transition ended). Confirm no such route relied on that.

Ruled out (verified NOT regressions)

Evidence for the checks that came back clean
  • Back-button focus vs. the dialog steal don't race. useScreenInitialFocus (which drives the HeaderWithBackButton back-button focus via useInitialFocusRef) bails immediately when isInsideDialog is true (useScreenInitialFocus/index.ts:44), while claimDialogFocus only runs because isInsideDialog/role="dialog" is true. Both read the same flag from the single DialogLabelProvider wrapping the RHP stack — the flag that enables one disables the other, so no double-focus.
  • Narrow RHP is unchanged. Non-dialog containers skip the new branch and keep the original keyboard-only claimInitialFocus path (useDialogContainerFocus/index.ts:41-45); narrow RHP has no role="dialog".
  • The announcement dedup rewrite silences nothing. I checked all ~15 web callers. The old code only re-announced an identical message when a dep changed (cleanup → re-run); with the message identical and shouldAnnounceMessage continuously true, the old effect never re-ran, so it didn't re-announce either. Every real re-announce path goes through a shouldAnnounceMessage false→true toggle (blur/close/typing-pause/countdown gate), and the new code resets previousMessageRef to '' on that false pass (index.ts:70-74), preserving all of them. Callers that fire repeated identical messages (useTaskCheckboxAccessibility, FormProvider, FormHelpMessage) already pass announcementKey, which bypasses the dedup.
  • useEffectuseLayoutEffect in useDialogLabelRegistration is a deliberate pre-paint change; pushLabel/popLabel are stable useCallbacks and this is a client-rendered web build, so no timing/ordering regression.

The one residual unknown is purely theoretical: a wide RHP that focuses an input via a raw autoFocus/.focus() that neither uses the arbiter nor completes before the transition ends. I didn't find a concrete screen that hits it (standard inputs go through useAutoFocusInput or focus on mount before the transition), so a browser pass on item 1 above would cover it.


This is an automated review. Reply with @MelvinBot <feedback> to refine it.

@mkhutornyi

mkhutornyi commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Bug: (screen reader not enabled) Enter key closes RHP

  1. Open App download links using mouse click (not keyboard)
  2. Press Enter key
bug.mov

RHP back button should be auto-focused only when this page is opened using keyboard Space or Enter

See production behavior:

production.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants