Show credited amount and both accounts for cross-border FX reimbursements

[ishpaul777]

Explanation of Change

Part of [Release 1] of "Allow Companies to Pay FX Costs for Cross-Border Reimbursements". This is the NewDot piece of #655929.

When a company pays the FX conversion cost on a cross-border reimbursement, the employee is credited an amount in their own deposit currency that differs from the report (settlement) total. The reimbursement action must therefore report the credited amount (in the employee's deposit currency) rather than the report total, and name both the funding (company) and receiving (employee) accounts.

This PR:

• Adds creditedAmount, debitedAmount, and creditedCurrency to the Report Onyx type. These are returned from Auth in OpenApp (see the companion Auth PR), so they are also added to whitelistedReportKeys, the stable report selector, and the DebugUtils report validators.
• Adds creditedAmount / creditedCurrency to the REIMBURSED report action's OriginalMessageReimbursed type (populated by Web-Expensify's getDisplayInformation).
• Adds a new iou.reimbursedCrossBorder string ("paid {amount} from account {debit} to account {credit}") across all languages.
• Updates getReimbursedMessage so that when creditedAmount is present, it renders the cross-border message using the credited amount and both account last-4s; otherwise it falls through to the existing wording.

Companion PRs:

• Auth: https://github.com/Expensify/Auth/pull/23119
• Web-Expensify: https://github.com/Expensify/Web-Expensify/pull/54798

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/655929
PROPOSAL:

Tests

1. On a workspace with global reimbursements enabled, submit and pay a cross-border expense report where the company pays the FX conversion cost.
2. Open the expense report in NewDot and locate the reimbursement system message.
3. Verify the message reads "paid {credited amount in the employee's deposit currency} from account {company account last 4} to account {employee account last 4}" instead of the report total.
4. Pay a regular (same-currency) report and verify the reimbursement message is unchanged ("reimbursed this report from the bank account ending in ...").

• Verify that no errors appear in the JS console

Offline tests

Same as tests. The reimbursement message is derived from Onyx data already present on the report action, so it renders identically offline once the data is synced.

QA Steps

Same as Tests.

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

[melvin-bot]

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

1. Look at the code and make sure there are no malicious changes.
2. Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

[codecov]

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/libs/DebugUtils.ts	69.01% <100.00%> (+0.18%)	⬆️
src/selectors/Report.ts	66.66% <ø> (ø)
src/types/utils/whitelistedReportKeys.ts	100.00% <ø> (ø)
src/libs/ReportActionsUtils.ts	77.93% <87.50%> (+0.03%)	⬆️
... and 11 files with indirect coverage changes