Repository navigation
Say which blocks differ when a move seems to change one - #13
Merged
Merged
Conversation
On a copy of a real server the check found 7 blocks different after a tribute move; on the made-up flat world it finds 0. Waystation sets no world block on a move, and the test cuts a platform into the terrain just before, so the world's own settling is the likely cause, but that isn't proven. The check now lists the blocks and what they changed between, and reports what changes in the 5 seconds before the move. It is as strict as before. Stand-in acceptance 163/169: the 5 that need the real setup, and the flaky op-break check. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On a stopped copy of the real server, "a move changes no block" found 7 of 67,840 blocks different after a tribute move. On the made-up flat world it finds 0.
Waystation's code sets no world block on a move, only display entities. The test cuts a flat platform into the chunk just before the check, and on real terrain that lets water, leaves and loose blocks settle. That's the likely cause, but it isn't proven.
So the check now:
It's as strict as before. The audit records the question as open, and that all five setup checks (BlueMap included) pass on the real copy.
Tested: acceptance on the stand-in, 163/169. The failures are the 5 that need the real server's setup, plus the known flaky op-break check. The move check passes with 0 differences.
Tests and docs only.
🤖 Generated with Claude Code