Repository navigation
ci: restore integration.yml loading; run and satisfy notices-current - #344
Merged
Merged
Conversation
Commit 8d3d585 (#312) moved four lines in integration.yml one column left: two comment lines and the two "run: sudo journalctl" lines in the syslog dump steps of run-rust-integration and run-rust-integration-postgres-novector. The run key no longer aligns with its sibling if and name keys, so the file is not valid YAML. GitHub cannot load it, and since 10:41 UTC on 2026-09-11 every run of this workflow is a zero-job failure named by the file path instead of "Integration Tests", for pull_request, merge_group and push alike. Branch protection on main requires the integration status. A status that can never be reported leaves every pull request opened since then BLOCKED with all other checks green (#341, #340, #343 at the time of writing), and the merge queue cannot advance. This restores the four lines to their previous indentation. Nothing else changes. Verified by parsing the file before and after: the main version fails with "while parsing a block collection", the fixed version loads with the seven expected jobs.
LeeroyHannigan
requested review from
amrith,
c33howard,
jcshepherd,
pdf-amzn,
robinnsc and
yesyayen
as code owners
September 11, 2026 15:51
LeeroyHannigan
changed the title
SOFTWARE-LICENSE-NOTICES-MONGODB.html was generated on the #331 branch, which was cut before #332 bumped the workspace to 0.1.11. The ten drifted lines are the workspace's own crates at 0.1.10; no third-party dependency or license changed. The Licenses workflow's "MongoDB notices must be current" step fails on main since the #331 merge. Signed-off-by: Lee Hannigan <lhnng@amazon.com> (cherry picked from commit 5268480)
…roup The notices-current job becomes a required status check. A required check whose workflow is path-filtered never reports on a pull request outside its paths, and that pull request can never merge, so the pull_request and merge_group triggers lose their path filters. The job takes under three minutes. The push trigger keeps its filter since it gates nothing. Signed-off-by: Lee Hannigan <lhnng@amazon.com> (cherry picked from commit 35f42a2)
LeeroyHannigan
changed the title
LeeroyHannigan
force-pushed
the
ci/fix-integration-workflow-indentation
branch
from
September 11, 2026 16:20
618e421 to
73707bf
Compare
pdf-amzn
approved these changes
Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Three commits, one fix for each link in a circle of required checks that could not report or could not pass:
ci(integration): restores four lines of indentation in.github/workflows/integration.yml(two syslog-dump comment lines and the tworun: sudo journalctl ...lines inrun-rust-integrationandrun-rust-integration-postgres-novector). fix(mongodb): dotted attribute paths #312 moved them one column left, sorun:no longer aligned with its siblingif:andname:keys and the file stopped parsing.chore(licenses): regeneratesSOFTWARE-LICENSE-NOTICES-MONGODB.htmlfor workspace version 0.1.11 (cherry-picked from chore(licenses): regenerate MongoDB notices for workspace version 0.1.11 #341, authorship preserved).ci(licenses): removes thepaths:filter from thepull_requestandmerge_grouptriggers oflicenses.ymlsonotices-currentreports on every pull request (cherry-picked from chore(licenses): regenerate MongoDB notices for workspace version 0.1.11 #341).This PR supersedes #341, whose two commits it carries unchanged.
Why
Since #312 merged (10:41 UTC, 2026-09-11) GitHub has been unable to load
integration.yml: every run is a zero-job failure named by the file path.mainrequires theintegrationstatus, so every PR opened since isBLOCKEDwith all other checks green. The merge queue merged #312, #291, and #313 without the check because a workflow that fails to load never starts a check run on the merge group, and the queue waits only for checks that start.Fixing
integration.ymlalone was blocked bynotices-current: its workflow is path-filtered and did not run here, so the required check sat at Expected. Carrying the trigger change made it run, and it then failed correctly because the MongoDB notices file onmainis stale. Both of those are #341's fixes, and #341 is blocked on the first commit here. One PR has to carry all three.Closes #
Testing done
Both workflow files parsed with PyYAML:
integration.ymlonmainfails with "while parsing a block collection"; the fixed file loads with all seven jobs;licenses.ymlloads with unfilteredpull_requestandmerge_grouptriggers.End to end on this PR: the first commit alone produced a complete "Integration Tests" run with all six jobs passing (15:51 to 16:11 UTC), the first since the breakage. The
notices-currentjob ran on the second revision and reported the stale notices file, which the cherry-picked regeneration fixes. This revision's checks are the proof for all three.Checklist
cargo test --workspace) (no Rust change)cargo fmt --check) (no Rust change)Storagetrait, auth model, on-disk format, or public CLI surface, an RFC has been accepted or is linked below. Otherwise, an ADR captures the decision (link below). (n/a)ADR / RFC: n/a
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache License 2.0 and I agree to the Developer Certificate of
Origin (DCO). See CONTRIBUTING.md for details.