Repository navigation
fix(storage-cassandra): use millisecond stream labels via shared helper - #400
Merged
Merged
Conversation
jcshepherd
requested review from
LeeroyHannigan,
amrith,
c33howard,
pdf-amzn,
robinnsc and
yesyayen
as code owners
October 14, 2026 19:38
…er (introduced in 9f43d03)
jcshepherd
force-pushed
the
feat/storage-cassandra-in-tree
branch
from
October 14, 2026 19:41
5b7c747 to
754de85
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Use millisecond stream labels via shared helper (introduced in 9f43d03)
Why
This addresses CI failure due to test_stream_table_reuse.py::test_recreate_stream_table_under_same_name failing. 9f43d03 introduced consistent millisecond-precision stream labels. storage-cassandra was still using second-precision: with this change storage-cassandra uses the same common method as the other engines for stream-label generation.
Testing done
cargo fmt --all -- --check
cargo clippy --all-targets -- -D warnings
./devtools/generate-software-license-notices --check
./devtools/generate-software-license-notices --check --backend mongodb
./devtools/generate-software-license-notices --check --backend cassandra
./devtools/generate-dev-license-notices --check
cargo test --workspace
cargo test -p extenddb-storage-cassandra --lib
cargo test -p extenddb-storage-cassandra --test ttl_integration -- --test-threads=1
cargo test -p extenddb-storage-cassandra --test direct_integration
devtools/run-cassandra-tests -- --pytest --parallel --filter "not import_export"
devtools/run-cassandra-tests -- --pytest --comprehensive --parallel --filter "not import_export"
devtools/run-cassandra-tests -- --rust-integration
cargo test --workspace)cargo fmt --check)cargo clippy -- -W clippy::pedantic)Storagetrait, auth model, on-diskformat, or public CLI surface, an RFC has been accepted or is linked
below. Otherwise, an ADR captures the decision (link below).
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache License 2.0 and I agree to the Developer Certificate of
Origin (DCO). See CONTRIBUTING.md for details.