Repository navigation
Feature/more align controllers - #372
Merged
Merged
Conversation
…ok out a crash too! (please envision this with a fun rhyme sequence its sooooo hard to convey it while in a commit message) OK THANK YOU!!!
1023941311414
requested changes
Oct 14, 2026
Collaborator
There was a problem hiding this comment.
Can you remove this change (maybe add to gitignore)?
Collaborator
There was a problem hiding this comment.
I notice that goalPose isn't used outside of assigning target. Maybe remove?
Collaborator
There was a problem hiding this comment.
Make everything private and make things final where you can; then name constants with UPPER_SNAKE_CASE
Collaborator
There was a problem hiding this comment.
Also make isComplete() public
Collaborator
There was a problem hiding this comment.
Can you add a blank line between imports and class header?
| import frc.robot.util.eventbus.events.IEvent; | ||
| import frc.robot.util.eventbus.handler.EventBus; | ||
|
|
||
| public class ListenerManager extends PeriodicBase { |
Collaborator
There was a problem hiding this comment.
Make these variables private, and final if possible
1023941311414
approved these changes
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.