Added CMake comments for install on Maxwell and Added feature of reconstuctor - #22
Closed
YellowSub17 wants to merge 14 commits into
Closed
YellowSub17 wants to merge 14 commits into
YellowSub17 wants to merge 14 commits into
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Allows saving images/scores incrementally per output step (e.g. one HDF5 file per iteration) instead of only after the full reconstruction finishes. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Collaborator
|
Is this ready to be merged? |
Author
|
I looks like like its added some of the other changes I've made to the reconstructor so it outputs while while running. Those changes aren't ready yet but we should talk about it irl. |
Author
|
Can't guarantee these changes wont be breaking. I'll keep working on it and make a more formal commit down the line. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes to cmake are all readmes or comments, so no change there.
In _spi_reconstructor, setting output_n to -1 will create and image or score output for every iteration.