Add option to include complete CI format details in texture filenames - #719
Add option to include complete CI format details in texture filenames#719LucretiaArc wants to merge 5 commits into
Conversation
Dragorn421
left a comment
There was a problem hiding this comment.
Thanks for the PR :)
So based on getTextureSuffixFromFormat your proposal is (when the option is checked in fast64 settings) replace .ci[48].png with .ci[48]-{rgba16,ia16}.png
I think that's a good idea and it looks easy to implement in oot at least
I think it'd be better to use an underscore _ as separator for consistency with oot's separators in texture file extension information (eg shared tluts are indicated with a .tlut_theTlutName. suffix) but lmk why you chose - if you have a reason
I'll raise the topic of this suffix idea in the n64brew discord since that may be used there too, may as well discuss it https://discord.com/channels/205520502922543113/974342113850445874/1533042856388853830
Out of curiosity what are you needing IA palettes for? I find them pretty much useless
I chose a hyphen mostly just as a sensible default, but if OoT already has an established separator for similar information then I'm happy to go with an underscore, pending any feedback from the N64brew discussion.
I don't have anything specific in mind, I'm more interested in making sure that the format is available for people who want to use it than actually using it in this case. I'm working on HackerSM64's support for CI texture image conversion, and it would be nice to build that in a way that supports IA palettes in case anyone wants to use them. |
|
If you want you can take a look at the document describing how oot handles pngs, in particular how it handles CI formats (which oot does use, contrarily to sm64 which afaik does not use any) https://github.com/zeldaret/oot/blob/main/docs/assets/images.md |
Texel format information is missing from the filenames of exported CI textures when using the "Save Textures As PNGs" option, which is a problem when converting those textures. Some toolchains could work around this by assuming the texel format (like OoT does), but to allow projects to fully support exports with PNG CI textures, the texel format should be included in the filename.
I haven't verified the adjustments in
z64/model_classes.pyvia export, but the result should be the same when the new option is disabled, and the toolchains for those projects would need to be modified to accept exports with the option enabled.