Repository navigation
The app runs with the settings and the retrieval it documents - #4
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
The settings in
.env, in the environment and in the--modelpresets take effect in every entry point, and the agent retrieves with the configuration the RAGAS evaluations measured.Changes
config.pyloads.envitself, so the CLI, the Streamlit UI,interactive.pyanddb_inspect.pysee the settings written there.configured_key()inagent.py: an empty key, a template value such asYOUR_OPENAI_API_KEY, orsk-...counts as unset, in the CLI and in the Streamlit key check and sidebar..env.exampleships the OpenAI placeholder the code recognises and leavesOPENROUTER_API_KEYcommented out.OPENROUTER_API_KEYis set, as the CLI does.--modelpreset brings its own temperature and max tokens to the run.db_inspect.pyandhybrid_retrieveembed withPINESCRIPT_EMBEDDING_MODEL.docs/ragas_tier1_comparison.md). The step stays available inrag_utils.--contextualflag alone;config.pyno longer readsPINESCRIPT_CONTEXTUAL_RETRIEVAL.Tests
ruff check .(0.16.1, as in CI) and the offline test suite pass on every commit, on Python 3.11 with pydantic-ai 2.69.0: 109 tests at the tip..envread byconfig.pyin a fresh interpreter; a placeholder OpenRouter key counts as unset; a preset's temperature and max tokens reachagent.run;retrievecallshybrid_retrievewithenable_rerank=False.tests/conftest.pykeeps the developer's.envout of the test process.TestModel, retrieval mocked, completes two turns, calls the retrieve tool and returns aPineScriptResult.