Repository navigation
fix(index): prefix leading-dash filepaths with ./ - #620
Merged
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved review comments were supplied, and regression coverage is included.
Pull request overview
Fixes conversion of filepaths beginning with - by prefixing them with ./.
Changes:
- Guards leading-dash paths before invoking UnRTF.
- Adds regression coverage and a fixture.
- Strengthens HTML output assertions.
File summaries
| File | Description |
|---|---|
test/index.test.js |
Adds regression coverage and tighter output checks. |
test/fixtures/-n.rtf |
Adds a leading-dash RTF fixture. |
src/index.js |
Guards leading-dash filepath arguments. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A filepath that starts with
-never converts, as UnRTF reads it as an option and has no--terminator.convert()now prefixes those paths with./, which resolves to the same file.Resolves CWE-88.
Checklist
npm test