Skip to content

feat(index): add cwd extra option - #625

Merged
Fdawgs merged 1 commit into
mainfrom
feat/conversion-cwd
Sep 3, 2026
Merged

Fdawgs merged 1 commit into
mainfrom
feat/conversion-cwd

Conversation

@Fdawgs

@Fdawgs Fdawgs commented Sep 1, 2026

Copy link
Copy Markdown
Owner

Checklist

Copilot AI lite review requested due to automatic review settings September 1, 2026 17:06

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note

Copilot was unable to run its full agentic suite in this review.

Pull request overview

Adds support for running the UnRTF conversion child process in a specified working directory (cwd), with accompanying tests and documentation updates to ensure embedded picture outputs and relative input paths behave correctly.

Changes:

  • Add extras.cwd to UnRTF#convert() and forward it to child_process.spawn().
  • Resolve relative input paths to absolute paths when cwd is used to avoid path resolution issues in the child process.
  • Add tests + README guidance for picture output isolation via per-conversion working directories.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
test/index.test.js Adds regression tests for picture outputs landing in the child cwd and for relative input paths when cwd differs.
src/index.js Implements extras.cwd support and adjusts input path handling when spawning the UnRTF child process.
README.md Updates recommended image-handling approach to use per-conversion temp directories via cwd.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread test/index.test.js Resolved
Comment thread src/index.js Resolved

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The implementation, tests, and documentation consistently cover the new option without unresolved issues.

Review details
  • Files reviewed: 3/3 changed files
  • Comments generated: 0 new
  • Review effort level: Balanced

@Fdawgs
Fdawgs merged commit 266771e into main Sep 3, 2026
19 checks passed
@Fdawgs
Fdawgs deleted the feat/conversion-cwd branch September 3, 2026 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants