Repository navigation
feat(index): add cwd extra option - #625
Merged
Merged
Conversation
There was a problem hiding this comment.
Note
Copilot was unable to run its full agentic suite in this review.
Pull request overview
Adds support for running the UnRTF conversion child process in a specified working directory (cwd), with accompanying tests and documentation updates to ensure embedded picture outputs and relative input paths behave correctly.
Changes:
- Add
extras.cwdtoUnRTF#convert()and forward it tochild_process.spawn(). - Resolve relative input paths to absolute paths when
cwdis used to avoid path resolution issues in the child process. - Add tests + README guidance for picture output isolation via per-conversion working directories.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| test/index.test.js | Adds regression tests for picture outputs landing in the child cwd and for relative input paths when cwd differs. |
| src/index.js | Implements extras.cwd support and adjusts input path handling when spawning the UnRTF child process. |
| README.md | Updates recommended image-handling approach to use per-conversion temp directories via cwd. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Fdawgs
force-pushed
the
feat/conversion-cwd
branch
from
September 3, 2026 06:54
ea17085 to
e718ed7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
npm test