Repository navigation
refactor(config): derive Default for PackageConfig and drop the repeated literals - #1311
Merged
Merged
Conversation
BryanFRD
enabled auto-merge (squash)
October 10, 2026 15:10
![ferrfleet[bot]](https://avatars.githubusercontent.com/in/4354888?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
This doesn't change behaviour. Every non-String field is an Option or a Vec, so the derived Default gives the same None / empty values the removed literals spelled out. The code search on main finds the old literal only in these 13 files, so none were missed. Replacing package_config() in init.rs with struct update syntax is the idiomatic way to do it. Nothing blocking.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1310
PackageConfig now derives Default. The 22 literals that listed every optional field as None or empty name only what they set and end with
..Default::default(). No behaviour change, net -272 lines.