Repository navigation
refactor: share the discovery collection and print bump types through Display - #1313
Merged
Merged
Conversation
BryanFRD
enabled auto-merge (squash)
October 10, 2026 15:23
![ferrfleet[bot]](https://avatars.githubusercontent.com/in/4354888?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
The BumpType Display impl (src/conventional_commits.rs:14) prints the same lowercase strings the old Debug + to_lowercase() produced, so the output is unchanged. collect_sorted keeps the same filter, sort and dedup behaviour for both entry points.
Nit: src/api_check/tests.rs:72 still builds commit_bump with format!("{commit_bump:?}").to_lowercase(). Switch it to commit_bump.to_string() so the test fixture uses the same path as build_report.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1312
discoveranddiscover_nodego through onecollect_sortedapi_checkandplan_interactiveuseBumpType's Display instead of Debug plus lowercase, same outputNo behaviour change.