Repository navigation
chore(deps): update github actions - #267
Conversation
There was a problem hiding this comment.
Three changes: digest bumps for docker/setup-qemu-action and docker/setup-buildx-action (both stay on v4, no tag change), and kindest/node v1.32.2 → v1.37.0 in .github/workflows/e2e.yml.
The node image bump is worth calling out as a positive: go.mod pins k8s.io/api, k8s.io/client-go, k8s.io/apimachinery all at v0.37.0, so the e2e cluster was previously running 5 minors behind the client library version skew the operator is built against. This bump actually removes an existing version mismatch rather than introducing one.
No API usage in this repo is affected by either docker action's digest-only update. CI is still finishing at review time (kind smoke test, CI/Test, CI/Lint, opengrep in progress), but everything that has completed so far is green and nothing points at these three lines.
Nothing blocking.
6751cf3 to
32f258f
Compare
SonarQube — aucune nouvelle issueComparaison entre le projet bac à sable de cette PR et la branche par défaut : SonarQube Community n'analyse pas les PR, ce delta est calculé côté CI. Détail |
d8f6383 to
ad6cd14
Compare
There was a problem hiding this comment.
Follow-up on my earlier approval at d8f6383. Two things changed since then.
CI has now finished, and kind smoke test fails on ad6cd14. The cause is the kindest/node bump, detail inline. That reverses the "nothing blocking" I gave when the job was still running: the version-skew argument for the bump still holds, it just needs the kind version bumped alongside it.
The branch also gained a third digest bump, github/codeql-action/upload-sarif b96794f → 2892aa5, which was not in what I reviewed. That digest is the v4.38.2 release commit on the v4 line, the # v4 comment stays accurate, and scorecard.yml passes no inputs that changed. No concern there. The two docker digests resolve to v4.4.0 (qemu) and v4.4.1 (buildx), both still under the v4 tag.
Automerge is on for this PR, so the failing required check is the only thing holding it.
ad6cd14 to
736c1cd
Compare
There was a problem hiding this comment.
Follow-up at 736c1cd. Renovate rebuilt the branch and added a Rust toolchain bump (1.98 to 1.99) in ci-rust.yml and cli-release.yml.
Nit: that bump does nothing as it stands. rust-toolchain.toml still has channel = "1.98", and rustup follows it for every cargo call made inside the repo. So the workflow installs 1.99, then lint, test and the release binaries still build on 1.98. Set channel = "1.99" in rust-toolchain.toml in this PR too, so the toolchain is defined in one place. If you'd rather keep Renovate from editing the workflows at all, drop the toolchain: input and let the file decide.
The e2e kind-action thread is still open: node_image is still v1.37.0 and kind is still on the action's default version. kind smoke test was still running when I posted this.
736c1cd to
7a5dd3d
Compare
There was a problem hiding this comment.
Follow-up at 7a5dd3d. Since 736c1cd, one thing changed: dtolnay/rust-toolchain moved from 6bed076 to 89b1218 in ci-rust.yml and cli-release.yml. 89b1218 is the current head of the action's stable branch, so the # stable comment is still accurate. The new commits add --force-non-host and a retry on checksum failures. That's fine.
The blocking kind-action thread is still open: e2e.yml hasn't changed, so kind still runs at the action's default v0.31.0 against kindest/node:v1.37.0. kind smoke test was still running when I posted this.
7a5dd3d to
af32fd2
Compare
There was a problem hiding this comment.
Follow-up at af32fd2. Renovate rebased the branch. The four workflow hunks are identical to 7a5dd3d, and scorecard.yml is no longer in the diff, so nothing new to review.
The blocking kind-action thread still applies: node_image is kindest/node:v1.37.0 while kind stays on the action's default v0.31.0, and version/kubectl_version are still unset. kind smoke test was still running when I posted this.
af32fd2 to
c6803a7
Compare
There was a problem hiding this comment.
Follow-up at 244885f. The blocking kind-action finding is fixed: e2e.yml now pins kind v0.33.0 and kubectl v1.37.0 for the v1.37.0 node image. I resolved that thread.
The PR no longer bumps dtolnay/rust-toolchain (it stays on 6bed076, same as main). kind smoke test was still running when I posted this, so I haven't seen it pass yet.
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
This PR contains the following updates:
37fe631→f87e5991f40c72→9901266v1.32.2→v1.37.01.98→1.99Release Notes
rust-lang/rust (rust)
v1.99.0Compare Source
==========================
Language
raw_borrows_via_referenceslint that checks for references that decay immediately into raw borrowsunconditional_paniclint to function calls that panic when the chunks/windows size is zero#[unsafe(naked)]functions to define C-variadic functions (#![feature(c_variadic_naked_functions)]).Sized#[my_macro] mod foo;. This allows outlined modules (mod foo;) anywhere in the body of a custom attribute or derive macro.overflowing_literalslint with repeated negation. For instance, it will now no longer lint on--128_i8, which is already detected by thearithmetic_overflowlint.invalid_runtime_symbol_definitionsandsuspicious_runtime_symbol_definitionslints#[path]attributes on inline modulesunreachable_cfg_select_predicateslint as part ofunusedlint groupasm!on x86UnsafeCellcan be accessed without going throughgetinvalid_reference_castinglint was adjusted accordinglyglobal_asm!docattribute is used on a macro invocationCompiler
-Ctarget-cpuinto a target-modifier for AVR, AMDGCN and NVPTXstatic_position_independent_executableson all gnu targetsPlatform Support
riscv64-unknown-linux-muslto Tier 2 with host toolsRefer to Rust's platform support page
for more information on Rust's tiered platform support.
Libraries
RangeInclusive(a..=branges) is now optimized better in some circumstances. As a side effect of this, the behavior ofRangeInclusivevalues that has already been exhausted (as an iterator) has changed. For example, the return values ofstart()andend()on such ranges may return different values, and using such ranges as slice indexes may have different behavior. These behaviors were not guaranteed to be stable, so these changes are considered to not be breaking changes.transmute_copyto accept?Sizedtypestransmute_copyto use a non-unwinding panicescape_debug_extcore::fmt::NumBufferinalloc(andstd)Stabilized APIs
IntoIteratorforBox<[T; N]>IntoIteratorfor&Box<[T; N]>IntoIteratorfor&mut Box<[T; N]>VecDeque::retain_backcore::ffi::VaListBox::into_non_nullBox::from_non_nullVec::into_partsVec::from_partscore::mem::size_of_val_rawcore::mem::align_of_val_rawcore::alloc::Layout::for_value_rawString::from_utf8_lossy_ownedstring::FromUtf8Error::into_utf8_lossyFusedIterator for StepBy<I>std::fs::set_timesstd::fs::set_times_nofollowCargo
debug. This is a preparation for transitioning thedevprofile away from debugging to give a saner default for faster development iterations. Currently there is no difference betweendevanddebugprofiles. docs #17214default-featuresfield. For example,serde = { workspace = true, default-features = false }now turns off default features even when the workspace definition enables them. On earlier editions,default-features = falseis ignored with a warning. (RFC 3945) #17126See also the full Cargo changelog
Rustdoc
unused_footnote_definitionrustdoc lintCompatibility Notes
std::i32::MAXshould be accessed viai32::MAXinstead.no_mangle_generic_itemsinto hard errorPin::new_uncheckedhas had its safety invariants changed slightlyletpatterns typecheckunsupported()instead offrom_raw_os_error(22)#[repr(simd)]was accidentally allowed on macro invocations on stable RustBox::leak: tell people to avoid unleakingdoc(cfg())into account when filtering doctests'staticsemicolon_in_expressions_from_non_local_macros) even when the macro comes from another crate. Previously, such warnings only appeared for macros from the same crate, to avoid showing warnings that can't be fixed locally; however, this masked problems, as integration tests from the crate providing the macro get compiled as a separate crate, so tests often wouldn't reveal this issue. If you encounter a lint like this, please make sure to report it to the crate providing the macro so they can fix it; don't just silence it in your own crate.semicolon_in_expressions_from_macros: Lint on non-local macros toosemicolon_in_expressions_from_macrosinto a separate lintCIenvironment variable. #17220Internal Changes
These changes do not affect any public interfaces of Rust, but they represent
significant improvements to the performance or internals of rustc and related
tools.
Configuration
📅 Schedule: (UTC)
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.
This PR has been generated by Mend Renovate CLI.