feat: add top-level dependency manifest - #170
Open
galargh wants to merge 3 commits into
Open
Conversation
galargh
changed the title
galargh
force-pushed
the
galargh/top-level-dependency-manifest
branch
from
August 13, 2026 14:01
e348479 to
5ef958f
Compare
…endency-manifest # Conflicts: # ci/README.md # ci/dependency-profiles.json # renovate.json # src/config.rs
…endency-manifest # Conflicts: # ci/dependency-profiles.json # src/config.rs
galargh
marked this pull request as ready for review
September 4, 2026 22:17
beck-8
reviewed
Sep 5, 2026
| base = profile.get("base") | ||
| if not isinstance(base, str) or not base: | ||
| raise ResolutionError(f"Profile {profile_name!r} base must be a string") | ||
|
|
Collaborator
There was a problem hiding this comment.
Prevent input errors, below rollback to default
Suggested change
| if not any(base in component for component in components.values()): | |
| raise ResolutionError( | |
| f"Profile {profile_name!r} base {base!r} does not match any " | |
| "known dependency selection" | |
| ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR ntroduces top-level dependencies.toml as the shared source of truth for runtime defaults and CI/scenario dependency profiles.
This removes the split where defaults lived in Rust code while CI had its own JSON profile manifest. The binary now embeds the same manifest that CI resolves, so version bumps and profile changes happen in one place.
dependencies.tomlThe manifest has three parts:
[dependencies.*]for runtime components used byfoc-devnet init, such as Lotus, Curio, filecoin-services, PDP, and multicall3[dev-dependencies.*]for scenario-only/client dependencies, such as Synapse SDK and filecoin-pin[profiles.*]for CI profile selection, where each profile declares a base selection and can override individual componentsEach dependency declares its repository with
git, plus profile selections such as:The resolver infers the strategy from the selected keys, including tag, tag_pattern, branch, commit, npm, pkg_pr_new, submodule_git, and bundled.
Testing
cargo fmt --checkcargo test config::tests::default_config_uses_manifest_dependency_defaultspython3 -m unittest scripts.tests.test_resolve_dependencies scripts.tests.test_scenario_dependencies