fix(synapse-e2e): support prepare piece sizes - #196
Merged
Conversation
Signed-off-by: Jakub Sztandera <oss@kubuxu.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The changes are small, localized to E2E helpers, and primarily adjust option-shaping for SDK compatibility with only minor naming clarity follow-ups.
Pull request overview
Updates the Synapse E2E scenario account-preparation helpers to be compatible with Synapse SDK variants that expect pieceSizes, while keeping backward compatibility by continuing to provide dataSize.
Changes:
- Pass both
dataSizeandpieceSizestosynapse.storage.prepare()for SDK 1.2 + master compatibility. - Reuse a single
optionsobject for the initial and follow-upprepare()calls. - Preserve
contextin the plain ERC-20 preparation path by including it in the reused options.
File summaries
| File | Description |
|---|---|
| scenarios/synapse-e2e/account.ts | Updates storage account preparation helpers to send both dataSize and pieceSizes to storage.prepare(), including context in the plain ERC-20 path. |
Review details
Suppressed comments (1)
scenarios/synapse-e2e/account.ts:109
- Same naming issue as above:
pieceSizeis passed through asdataSizeand current usage passes file byte lengths (and even1nin create-dataset.ts). Renaming the parameter todataSize(or explicitly accepting bothdataSizeandpieceSize) would make the intent clearer and reduce the chance of mixing up padded piece sizes vs raw data sizes.
export async function prepareAccountWithPlainErc20(
synapse: ScenarioSynapse,
pieceSize: bigint,
context: StorageContext
): Promise<AccountState> {
const options = {
context,
// TODO: Remove dataSize after dropping Synapse SDK 1.2 compatibility.
dataSize: pieceSize,
pieceSizes: [pieceSize],
}
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
beck-8
approved these changes
Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary