Skip to content

fix(synapse-e2e): support prepare piece sizes - #196

Merged
Kubuxu merged 1 commit into
mainfrom
fix/synapse-prepare-piece-sizes
Sep 3, 2026
Merged

fix(synapse-e2e): support prepare piece sizes#196
Kubuxu merged 1 commit into
mainfrom
fix/synapse-prepare-piece-sizes

Conversation

@Kubuxu

@Kubuxu Kubuxu commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Summary

  • pass both dataSize and pieceSizes to Synapse prepare calls for SDK 1.2 and master compatibility
  • preserve the storage context in the plain ERC-20 preparation path
  • rename helper parameters to pieceSize and mark dataSize for removal after SDK 1.2 support ends

Signed-off-by: Jakub Sztandera <oss@kubuxu.com>
@Kubuxu
Kubuxu requested review from beck-8 and rvagg as code owners September 3, 2026 12:55
Copilot AI lite review requested due to automatic review settings September 3, 2026 12:55
@FilOzzy FilOzzy added this to FOC Sep 3, 2026
@github-project-automation github-project-automation Bot moved this to 📌 Triage in FOC Sep 3, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The changes are small, localized to E2E helpers, and primarily adjust option-shaping for SDK compatibility with only minor naming clarity follow-ups.

Pull request overview

Updates the Synapse E2E scenario account-preparation helpers to be compatible with Synapse SDK variants that expect pieceSizes, while keeping backward compatibility by continuing to provide dataSize.

Changes:

  • Pass both dataSize and pieceSizes to synapse.storage.prepare() for SDK 1.2 + master compatibility.
  • Reuse a single options object for the initial and follow-up prepare() calls.
  • Preserve context in the plain ERC-20 preparation path by including it in the reused options.
File summaries
File Description
scenarios/synapse-e2e/account.ts Updates storage account preparation helpers to send both dataSize and pieceSizes to storage.prepare(), including context in the plain ERC-20 path.
Review details

Suppressed comments (1)

scenarios/synapse-e2e/account.ts:109

  • Same naming issue as above: pieceSize is passed through as dataSize and current usage passes file byte lengths (and even 1n in create-dataset.ts). Renaming the parameter to dataSize (or explicitly accepting both dataSize and pieceSize) would make the intent clearer and reduce the chance of mixing up padded piece sizes vs raw data sizes.
export async function prepareAccountWithPlainErc20(
  synapse: ScenarioSynapse,
  pieceSize: bigint,
  context: StorageContext
): Promise<AccountState> {
  const options = {
    context,
    // TODO: Remove dataSize after dropping Synapse SDK 1.2 compatibility.
    dataSize: pieceSize,
    pieceSizes: [pieceSize],
  }
  • Files reviewed: 1/1 changed files
  • Comments generated: 1
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread scenarios/synapse-e2e/account.ts
@github-project-automation github-project-automation Bot moved this from 📌 Triage to ✔️ Approved by reviewer in FOC Sep 3, 2026
@Kubuxu
Kubuxu merged commit 458b7fe into main Sep 3, 2026
5 checks passed
@Kubuxu
Kubuxu deleted the fix/synapse-prepare-piece-sizes branch September 3, 2026 13:21
@github-project-automation github-project-automation Bot moved this from ✔️ Approved by reviewer to 🎉 Done in FOC Sep 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 🎉 Done

Development

Successfully merging this pull request may close these issues.

4 participants