Normalize wrapped Laplace scalar parameters#4273
Closed
FlorianPfaff wants to merge 17 commits into
Closed
Conversation
Contributor
✅MegaLinter analysis: Success
Notices📣 MegaLinter 9.5.0 is out! Discover the new features and security recommendations in the release announcement. (Skip this info by defining See detailed reports in MegaLinter artifacts Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining
|
98db971 to
a1440d7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Bug
WrappedLaplaceDistributiondocumentslambda_andkappa_as scalars, but_validate_positive_scalar()accepted arrays with shape(1,)and returned them unchanged.This made scalar behavior depend on how numerically identical parameters were supplied. With
lambda_=2.0andkappa_=1.3, scalarpdf()andtrigonometric_moment()calls return scalar values. With one-element arrays such asnp.array([2.0]), the retained singleton axes broadcast through the formulas and produce arrays with shape(1,)instead.That accidental batch axis can break scalar consumers and makes the wrapped-Laplace API inconsistent with its scalar parameter contract.
Fix
After validating that a parameter is either zero-dimensional or a one-element array, reshape the latter to a zero-dimensional backend value. Numerical values and valid scalar behavior are unchanged.
Validation
lambda_andkappavalues have shape()pdf()and first trigonometric-moment outputs also have shape()python -m py_compile(1,)parameters normalize to()main: two commits ahead, zero behind; two production lines and one focused regression file changedThe full backend and lint matrix is delegated to GitHub Actions.